Javascript Disabled Detected

You currently have javascript disabled. Several functions may not work. Please re-enable javascript to access full functionality.

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

Issue ID
#006066
Severity
3 - Medium
Status
Fixed

Issue Confirmations

Yes (5)No (0)

0

EDP should no longer increase final damage

Posted by Hercules Bot on 20 June 2012 - 03:02 AM

Originally posted by MarkZD
Here's my EDP fix, based upon rA comment source, iRO source and etc.

   if( sc->data[SC_EDP] ){
		switch(skill_num){
		 case AS_SPLASHER:		 case AS_VENOMKNIFE:
		 case ASC_METEORASSAULT:
		 break;
#ifdef RENEWAL_EDP
         case AS_SONICBLOW:
		 case ASC_BREAKER:
		 case GC_COUNTERSLASH:
		 case GC_CROSSIMPACT:
		  ATK_RATE(50); // only modifier is halved but still benefit with the atk and weapon bonus
		  break;
#else
		 case ASC_BREAKER: break;
		 default:
		  ATK_ADDRATE(sc->data[SC_EDP]->val3);//It doesn't exist in RENEWAL
#endif
		}
   }

This "atk_addrate" is from PRE because in Renewal, base atk and weapon attack are increased instead of this final addition, and base&weapon attack are coded in status.c

This will also fix huge damage of normal attack and skills in RE like Rolling Cutter: http://sourceforge.n...hangeset/16322/

Also, in status.c:
wATK should be increased by 5 & bATK by 4, but it's inverted

Also, it should be eATK not bATK, but we need Renewal atk changes to do that perfectlly.