Issue Information
-
#001259
-
3 - Medium
-
Fixed
Issue Confirmations
-
Yes (0)No (0)
Originally posted by theultramage
http://www.eathena.w...er&showbug=1259
A random test of MVP rewards on aegis showed that eathena has messed up mvp exp reward logic.
Aegis has only a single column for the exp reward, called 'exppercent'. Some wise guy interpreted that as 'chance to get exp reward', and also added another column to specify the value received.
Testing with various values showed that this is not the case. The column specifies the percentage of the normal base exp kill reward. For all of the mvps, this is set to 50% in that table. Also, the exp reward is given every time, and regardless of the percentage setting.
One fix would be to make eathena ignore the value setting, and change the semantics of the percentage setting. And get rid of the mvp_exp config settings.
Another would be to rewrite all percentage values to 100% and keep the rest as it is.
http://www.eathena.w...er&showbug=1259
A random test of MVP rewards on aegis showed that eathena has messed up mvp exp reward logic.
Aegis has only a single column for the exp reward, called 'exppercent'. Some wise guy interpreted that as 'chance to get exp reward', and also added another column to specify the value received.
Testing with various values showed that this is not the case. The column specifies the percentage of the normal base exp kill reward. For all of the mvps, this is set to 50% in that table. Also, the exp reward is given every time, and regardless of the percentage setting.
One fix would be to make eathena ignore the value setting, and change the semantics of the percentage setting. And get rid of the mvp_exp config settings.
Another would be to rewrite all percentage values to 100% and keep the rest as it is.