Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #001335

  • 0 - None Assigned

  • Fixed

Issue Confirmations

  • Yes (2)No (0)
Photo

Poor Scripting Prevents Unloading From Maps

Posted by Hercules Bot on 08 April 2008 - 07:52 AM

Originally posted by theultramage
http://www.eathena.w...er&showbug=1335

This has been annoying me for a loooong time. For some reason, scripters think that this is the best way to write a npc that appears in multiple places:
some_particular_city,x,y,d    script   somenpc viewid,{ ... }
some_other_city,x,y,d  duplicate(somenpc) somenpc#1  viewid
yet_another_city,x,y,d duplicate(somenpc) somenpc#2  viewid
This design requires that the first map must be present at the time of loading.
Otherwise, script loading will skip it and afterwards all duplicates will fail to load too.

Is it that much of a problem to make a floating mapless npc and clone from that?

Originally posted by Brian
Updating status to: Fixed in [rev=15075/trunk/npc/custom/].

Originally posted by Gepard
Reopening, since there are still duplicates that are not made from mapless (floating) NPCs, for example:
  • ConMessenger
  • SmileHelper
  • TheSign
  • VotingStaffCCE

See also [bug:1395].

Originally posted by Brian
Updating status to: Fixed in [rev=15798]