Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #001771

  • 0 - None Assigned

  • Confirmed

Issue Confirmations

  • Yes (0)No (0)
Photo

Storage Code Removal

Posted by Hercules Bot on 25 June 2008 - 10:30 AM

Originally posted by theultramage
http://www.eathena.w...er&showbug=1771

The storage saving mechanism works independently of char inventory saving. Since saves are done over a TCP connection and asynchronously, it is not really possible to make these operations transaction-safe. This would mean that if one of the two fails and the other succeeds, you get item duplication or item loss.

A suggestion is to change the way storage is being handled. Instead of keeping it in a separate cache and saving it at suitable times, instead make it a property of a character, like inventory or cart is. Since there can only be one account active at the same time, this approach is feasible.

Of course, it would require some hacking - since each storage entry is about 20 bytes and there are 300-1000 of them, this would inflate the session data structure by ~10%. Not sure if this is still acceptable.