Issue Information
-
#002307
-
4 - High
-
Fixed
Issue Confirmations
-
Yes (2)No (0)
0
Mail attachments bug (possible loss of items)
Posted by Hercules Bot on 05 October 2008 - 04:14 AM
Originally posted by Gepard
http://www.eathena.w...er&showbug=2307
Goes like this:
1. Open your mailbox. Open a mail with attachment.
2. Make map-server disconnect from char-server.
3. Request your attachment. Because there is no char server you won't get the item, but attachment will be removed from mapserver memory.
4. It is now impossible to delete the mail, so it's time to make map-server reconnect to char-server.
5. Now delete the mail. Because that is the mapserver that checks for attachment (and it thinks there is no attachment), the request is processed even though you didn't get the items. Mail is removed, attachment is lost. Players cry :cry:
I'm not sure how to fix it. Some ideas are: reload all mails when char and map reconnect, check for attachment on char-server not only map-server, don't delete attachment on map-server if there is no char-server.
http://www.eathena.w...er&showbug=2307
Goes like this:
1. Open your mailbox. Open a mail with attachment.
2. Make map-server disconnect from char-server.
3. Request your attachment. Because there is no char server you won't get the item, but attachment will be removed from mapserver memory.
4. It is now impossible to delete the mail, so it's time to make map-server reconnect to char-server.
5. Now delete the mail. Because that is the mapserver that checks for attachment (and it thinks there is no attachment), the request is processed even though you didn't get the items. Mail is removed, attachment is lost. Players cry :cry:
I'm not sure how to fix it. Some ideas are: reload all mails when char and map reconnect, check for attachment on char-server not only map-server, don't delete attachment on map-server if there is no char-server.
Originally posted by malufett
hmm..what if don't process the transaction until char server is available..and let the user try again..
I'm not sure how to fix it. Some ideas are: reload all mails when char and map reconnect, check for attachment on char-server not only map-server, don't delete attachment on map-server if there is no char-server.
hmm..what if don't process the transaction until char server is available..and let the user try again..
Originally posted by mkbu95
I'd go for ultramage suggestion, chrif_isconnected on it.
I'd go for ultramage suggestion, chrif_isconnected on it.
Originally posted by malufett
hahaha..I didn't read the Ultramage post a while ago..anyway same idea..so +1I'd go for ultramage suggestion, chrif_isconnected on it.
Originally posted by mkbu95
Fixed in [rev=16953].
Fixed in [rev=16953].