Issue Information
-
#003179
-
2 - Fair
-
Fixed
Issue Confirmations
-
Yes (0)No (0)
Originally posted by theultramage
http://www.eathena.w...er&showbug=3179
There are several battle config settings that get 'post-processed' after loading them, limiting their values to some range, or outright changing them:
This doesn't work very well if you have to change them, say by using @setbattleflag. In this case it sets their raw value, causing unexpected behavior.
My suggestion is to get rid of battle_adjust_conf() completely, and do these adjustments in places where the config values are used.
http://www.eathena.w...er&showbug=3179
There are several battle config settings that get 'post-processed' after loading them, limiting their values to some range, or outright changing them:
CODE
battle_config.monster_max_aspd = 2000 - battle_config.monster_max_aspd*10;
battle_config.max_aspd = 2000 - battle_config.max_aspd*10;
battle_config.max_walk_speed = 100*DEFAULT_WALK_SPEED/battle_config.max_walk_speed;
battle_config.max_cart_weight *= 10;
battle_config.max_aspd = 2000 - battle_config.max_aspd*10;
battle_config.max_walk_speed = 100*DEFAULT_WALK_SPEED/battle_config.max_walk_speed;
battle_config.max_cart_weight *= 10;
This doesn't work very well if you have to change them, say by using @setbattleflag. In this case it sets their raw value, causing unexpected behavior.
My suggestion is to get rid of battle_adjust_conf() completely, and do these adjustments in places where the config values are used.