Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

Issue Confirmations

  • Yes (0)No (0)
Photo

calculated config settings and @setbattleflag

Posted by Hercules Bot on 04 June 2009 - 09:29 AM

Originally posted by theultramage
http://www.eathena.w...er&showbug=3179

There are several battle config settings that get 'post-processed' after loading them, limiting their values to some range, or outright changing them:
CODE
    battle_config.monster_max_aspd = 2000 - battle_config.monster_max_aspd*10;
    battle_config.max_aspd = 2000 - battle_config.max_aspd*10;
    battle_config.max_walk_speed = 100*DEFAULT_WALK_SPEED/battle_config.max_walk_speed;
    battle_config.max_cart_weight *= 10;

This doesn't work very well if you have to change them, say by using @setbattleflag. In this case it sets their raw value, causing unexpected behavior.
My suggestion is to get rid of battle_adjust_conf() completely, and do these adjustments in places where the config values are used.

Originally posted by Ind
was fixed in a previous eA revision