Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

Issue Confirmations

  • Yes (1)No (0)
Photo

Orc's Memory - 2 Player in a Party

Posted by Hercules Bot on 24 December 2009 - 08:57 PM

Originally posted by Arcenciel
http://www.eathena.w...er&showbug=3970

After registration with 2 people online in the party, the party is still allowed to do the Instance even if the other person is offline and there is only one person in the party.

Breaks the 2+ requirement.

Originally posted by Masao
Unfortunatly this is one of the Problems we're dealing with since ages in eA, but also as far as i know, it works this way too on official servers?

If it doesn't work like that on official servers, someone can provide ma link with proof for it?

Originally posted by sizenine
Also it doesn't check for base level requirement of other partymates

Originally posted by Masao
Fixed in [rev=16107]

About the lvl issue, well i could fix it but i won't, since i myself at least would need to use sql querys in order to do so, which would end up in performance issues.

But if anyone else knows how to do this in another way, feel free to tell me.

Originally posted by Lemongrass

Fixed in [rev=16107]About the lvl issue, well i could fix it but i won't, since i myself at least would need to use sql querys in order to do so, which would end up in performance issues.But if anyone else knows how to do this in another way, feel free to tell me.


if you already check if the player is online, just attach him and check his baselevel?

or do something like(pseudo code):

array = getparymembers();
count = 1; // player himself

for( i = 0; i < count(array); i++ ){
    if( attach( array[i] ) && baselevel >= requiredlevel ){
       // player is online and attached and has the right baselevel
       count++;
    }
}

get my idea?

Edited by Lemongrass, 12 May 2012 - 11:00 PM.


Originally posted by QQfoolsorellina

Fixed in [rev=16107]About the lvl issue, well i could fix it but i won't, since i myself at least would need to use sql querys in order to do so, which would end up in performance issues.But if anyone else knows how to do this in another way, feel free to tell me.


Hi Masao,
it still bugged

I notice  the .@loggedin value  always 0


my temporary solution:

	getpartymember(.@party_id),1;
	getpartymember(.@party_id),2;
	set .@partymembercount,$@partymembercount;
	copyarray .@partymemberaid,$@partymemberaid[0],.@partymembercount;
	copyarray .@partymembercid,$@partymembercid[0],.@partymembercount;
	for(set .@i,0; .@i < .@partymembercount; set .@i,.@i+1){
		if(isloggedin(.@partymemberaid[.@i],.@partymembercid[.@i])){
			set .@loggedin,.@loggedin+1;
		}
	}


Edited by QQfoolsorellina, 13 May 2012 - 02:29 PM.


Originally posted by Masao
@QQfoolsorellina : No clue why it doesn't work for you, i've texted that script several times on my test server, using the original instance npc's and an test npc to check the isloggedin function itself, and it always worked for me.

Originally posted by QQfoolsorellina

@QQfoolsorellina : No clue why it doesn't work for you, i've texted that script several times on my test server, using the original instance npc's and an test npc to check the isloggedin function itself, and it always worked for me.



I cant entry the instant it always show the below message

http://3.imgland.net/7vu5h.jpg



in picture  the announce '0'  is   my addtion script  to show  the value of  .@loggedin

	for(set .@i,0; .@i < .@partymembercount; set .@i,.@i+1){
		if(isloggedin($@partymemberaid[.@i],$@partymembercid[.@i])){
			set .@loggedin,.@loggedin+1;
		}
	}
   + announce ""+.@loggedin,8;// this is the only  script  add by me

Edited by QQfoolsorellina, 13 May 2012 - 02:48 PM.


Originally posted by Masao
Should finally be fixed in [rev=16111] i hope.

Originally posted by Lemongrass

Should finally be fixed in [rev=16111] i hope.


Since you seem to ignore me, here's a small diff for a fix that should work and even provide the possibility to check the required level of the online players.

Please mind that I haven't had the time to test it on a running server, but there weren't any compiling issues.

Feel free to add it to the SVN, but please add a credit if you do so.

Edited by Lemongrass, 14 May 2012 - 04:06 PM.


Originally posted by Masao
@Lemongrass

I'm not ignoring you, but this report is about the issue of 2 players which need to be online and in a party in order to join the instance ^^ The level issue is something different, which i sure will also take care of some time, and thank you for your input, but it's not on position 1. on my To-Do list.

Originally posted by Masao
Fixed in [rev=16135] .