Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #004629

  • 1 - Low

  • Fixed

Issue Confirmations

  • Yes (0)No (0)
Photo

Friend list missing state tracking

Posted by Hercules Bot on 09 December 2010 - 01:31 PM

Originally posted by Ai4rei
http://www.eathena.w...er&showbug=4629

In the beginning adding friends was one-sided and without confirmation. In r1602 the confirmation mechanism was introduced, which required the player being added to agree to the process. Due to the fact, that the server does not track of the state, whether or not an invitation has been sent, this allows adding oneself into others' friend list without their consent by sending clif_parse_FriendsListReply packet through 3rd-party means such as WPE.

Possible solution would be to track of the char_id of last sent invitation and accepting only reply from this char_id.

8769

This post has been edited by Ai4rei: Dec 9 2010, 05:33 AM

Originally posted by Ind
Fixed in [rev=15118]

Originally posted by Erid
There is a minor typo in the comment at pc.h:
/**
* Guarantees your friend request is legit (for bugreport:6429)
**/
int friend_req;

It should say 4629 instead of 6429.

Originally posted by Ind
Thanks. Fixed in [rev=15136]