Issue Information
-
#004645
-
2 - Fair
-
Confirmed
Issue Confirmations
-
Yes (1)No (0)
Originally posted by Harbin
http://www.eathena.w...er&showbug=4645
Patch => http://pastebin.com/CRvSxJQe
This fixes -g flag being enabled regardless of --enable-debug switch status, and also enables --enable-debug by default + simplifies CFLAG hassle a bit.
This post has been edited by Harbin: Dec 15 2010, 04:58 PM
http://www.eathena.w...er&showbug=4645
Patch => http://pastebin.com/CRvSxJQe
This fixes -g flag being enabled regardless of --enable-debug switch status, and also enables --enable-debug by default + simplifies CFLAG hassle a bit.
This post has been edited by Harbin: Dec 15 2010, 04:58 PM
Originally posted by Ind
I'll confirm because it seems legit to me, but I'll not fix because I'm not so skilled in shell lang. hopefully a skilled dev in this area will look into this issue and get it fixed
I'll confirm because it seems legit to me, but I'll not fix because I'm not so skilled in shell lang. hopefully a skilled dev in this area will look into this issue and get it fixed
Originally posted by Sirius_Black
Ill take the responsibility of that issue.
More information within the next 24h
Thanks for the report / submitted patch ^^;
Greetings,
Florian
Ill take the responsibility of that issue.
More information within the next 24h
Thanks for the report / submitted patch ^^;
Greetings,
Florian
This is still an issue as of the latest version.
AC_PROG_CC overrides CFLAGS with -g -O2. The solution is saving the user set CFLAGS before calling AC_PROG_CC then readding them to the created CFLAGS.
like so:
Also there is another issue with enable-debug. It only adds the -g flag to the CFLAGS not to the LDFLAGS. This obviously makes no sense at all.
AC_PROG_CC overrides CFLAGS with -g -O2. The solution is saving the user set CFLAGS before calling AC_PROG_CC then readding them to the created CFLAGS.
like so:
OLD_CFLAGS="$CFLAGS" AC_PROG_MAKE_SET AC_PROG_CC AC_PROG_CPP AC_PATH_PROG(AR, ar) AC_LANG([C]) CFLAGS="$OLD_CFLAGS -pipe -ffast-math -Wall -Wextra -Wno-sign-compare"
Also there is another issue with enable-debug. It only adds the -g flag to the CFLAGS not to the LDFLAGS. This obviously makes no sense at all.
Edited by Valo, 01 October 2014 - 02:59 AM.