Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #004964

  • 0 - None Assigned

  • Unable to Fix

Issue Confirmations

  • Yes (0)No (0)
Photo

instanced npc without instance_init error

Posted by Hercules Bot on 14 June 2011 - 07:46 AM

Originally posted by ~AnnieRuru~
http://www.eathena.w...er&showbug=4964

ok ... in script_commands.txt this already explained

QUOTE (eAthena\doc\script_commands.txt)
*instance_init <instance id>;

Initializes the instance given by <instance id>. This copies all NPCs from the
source maps to the instanced maps.


but if I forgotten to use this command, the server doesn't tell any error

CODE
prontera,156,177,5    script    kjdhskjdh    100,{
    if ( getcharid(1) == 0 ) end;
    if ( set(.@ins, instance_create( "Poring Fun", getcharid(1) ) ) < 0 ) end;
    if ( instance_attachmap("2@cata", .@ins) == "" ) {
        instance_destroy .@ins;
        end;
    }
    warp "2@cata", 79,55;
    instance_set_timeout 60, 5;
//    instance_init .@ins; // forgot ...
    end;
}
2@cata,79,55,0    script    test    100,{ // this npc isn't show up, and NO ERROR ?
    select "destroy instance";
    instance_destroy;
    end;
}


it only tells error when someone hits an OnTouch npc

CODE
prontera,156,177,5    script    kjdhskjdh    100,{
    if ( getcharid(1) == 0 ) end;
    if ( set(.@ins, instance_create( "Poring Fun", getcharid(1) ) ) < 0 ) end;
    if ( instance_attachmap("2@cata", .@ins) == "" ) {
        instance_destroy .@ins;
        end;
    }
    warp "2@cata", 79,55;
    instance_set_timeout 60, 5;
//    instance_init .@ins; // forgot ...
    end;
}
2@cata,79,55,0    script    test    -1,0,0,{ // now a weird error
OnTouch:
    announce "Welcome "+ strcharinfo(0) +" into our private ... ERROR room !", bc_map;
    // ok ... at least bc_map works fine, no need to use instance_announce if there's a RID
    end;
}


CODE
[Error]: npc_touch_areanpc : stray NPC cell on coordinates '001#2@cata',79,55


and this error doesn't make sense too

it should say something like... failed to copy ... or create instance npc without instance_init

This post has been edited by ~AnnieRuru~: Jun 14 2011, 12:48 AM

Originally posted by GodLesZ
First of all, the strying cell message has been clarified a bit.
But its not possible to popup a message if an npc should be placed on a not-yet loaded map.

Maybe we should thinking about a way for testing issues like this using a server mode or something like this.