Issue Information
-
#005018
-
3 - Medium
-
Fixed
Issue Confirmations
-
Yes (5)No (0)
0
Originally posted by Epoque
http://www.eathena.w...er&showbug=5018
I've just implemented an NPC which will grant a player ALL_BUYING_STORE once paid for. I expected: skill "ALL_BUYING_STORE", 1, 0; to permanently grant the player the skill. However whenever I logout and login on the character, the skill is removed (and must talk to the NPC again). I'm not sure if this is a skill specific problem, or a general script problem.
The NPC code is below.
Upon re-login, the skill has been lost. It seems permanent skills are saved in the database, but not sent to the client upon login.
This post has been edited by Epoque: Aug 7 2011, 09:22 PM
http://www.eathena.w...er&showbug=5018
I've just implemented an NPC which will grant a player ALL_BUYING_STORE once paid for. I expected: skill "ALL_BUYING_STORE", 1, 0; to permanently grant the player the skill. However whenever I logout and login on the character, the skill is removed (and must talk to the NPC again). I'm not sure if this is a skill specific problem, or a general script problem.
The NPC code is below.
CODE
set Zeny, Zeny - 500000;
set BUYING_STORE, 1;
skill "ALL_BUYING_STORE", 1, 0;
set BUYING_STORE, 1;
skill "ALL_BUYING_STORE", 1, 0;
Upon re-login, the skill has been lost. It seems permanent skills are saved in the database, but not sent to the client upon login.
This post has been edited by Epoque: Aug 7 2011, 09:22 PM
Originally posted by Ind
I couldn't reproduce, works fine on latest rAthena
I couldn't reproduce, works fine on latest rAthena
Originally posted by Ind
Issue identified. Working on it.
Issue identified. Working on it.
Originally posted by Ind
Should be fixed in [rev=15825] reverted in [rev=15827]
Originally posted by Rozeniiz
when relogin buying store skill still hide
when relogin buying store skill still hide
Originally posted by Earthlingz
couldnt we just add them to all jobs skill_tree.txt?
or probably make something like inherit the jobs so the skills doesnt need to put to each jobs just like the client skilltreeview and jobinheritlist luas (sounds like a not easy job to do though)
couldnt we just add them to all jobs skill_tree.txt?
or probably make something like inherit the jobs so the skills doesnt need to put to each jobs just like the client skilltreeview and jobinheritlist luas (sounds like a not easy job to do though)
Originally posted by Rozeniiz
i try with merchant when i logout and login again the skill is disappear
i try with merchant when i logout and login again the skill is disappear
Originally posted by Vali
bump
bump
Originally posted by Altimage
bump
bump
Originally posted by mkbu95
I think I did fix that in [rev=16908].
Let me know if I broke something/didn't fix properly.
I think I did fix that in [rev=16908].
Let me know if I broke something/didn't fix properly.
Originally posted by Ind
you fixed this particular case; but overall any script-granted skill that is not preset in their skill tree goes away on relog (because they're not properly saved in the db)I think I did fix that in [rev=16908].Let me know if I broke something/didn't fix properly.
will update this reply with link to commit once it reaches the repository.
Finally 
I tried fixing this on late nov but my fix was a bit of messy !_!
I tried fixing this on late nov but my fix was a bit of messy !_!
