Javascript Disabled Detected

You currently have javascript disabled. Several functions may not work. Please re-enable javascript to access full functionality.

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

Issue ID
#005052
Severity
0 - None Assigned
Status
Fixed

Issue Confirmations

Yes (1)No (0)

0

Asura combo stopped working

Posted by Hercules Bot on 11 September 2011 - 11:53 PM

Originally posted by Kazukin
http://www.eathena.w...er&showbug=5052

After r14939 Asura Strike is broken when casted as part of a combo. Issue is that it is invoked with no target_id and as result it takes oneself as target_id (default target). This causes sp, spirit spheres and fury to be consumed but no damage is done (since you are the target).

Quickfix:

QUOTE

unit_skilluse_id2()

if ( target_id == src->id &&
        skill_get_inf(skill_num)&INF_SELF_SKILL &&
        skill_get_inf2(skill_num)&INF2_NO_TARGET_SELF )
    {
        target_id = ud->target; //Auto-select target. [Skotlex]
        temp = 1;
-   }
+  } else //Asura combo
+  if (skill_num == MO_EXTREMITYFIST &&
+      sc && sc->data[SC_COMBO] &&
+     (sc->data[SC_COMBO]->val1 == MO_COMBOFINISH ||
+      sc->data[SC_COMBO]->val1 == CH_TIGERFIST ||
+      sc->data[SC_COMBO]->val1 == CH_CHAINCRUSH))
+  {
+      target_id = ud->target;
+      temp = 1;
+  }

Also, packet 0x07e1 is still commented on the packet_db, maybe it should be uncommented even if its size is already defined on clif.c

This post has been edited by Kazukin: Sep 11 2011, 05:17 PM