Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

Issue Confirmations

  • Yes (1)No (1)
Photo

Aura Blade

Posted by Hercules Bot on 25 January 2012 - 12:34 PM

Originally posted by calciumkid
It gives the atk bonus but the skill doesn't ignore DEF as it's supposed to.

no aura
Posted Image

aura
Posted Image

incantation samurai card

Posted Image

Confirmations?

Originally posted by calciumkid
Bumpity.

Originally posted by Protimus
This is strange, because this skill don't  have these bonus on source code and any modifications to increment flags with defense immunity.

set_sc( LK_AURABLADE		 , SC_AURABLADE	   , SI_AURABLADE	   , SCB_NONE );

Don't have bonus.

355,0,6,4,0,0x1,0,5,1,no,0,0,0,weapon,0, LK_AURABLADE,Aura Blade

0x01 - No damage skill


What can happen is the code are in the wrong place, pulling vit calculations and consequently reducing the defense.

In battle.c check these code:


//Post skill/vit reduction damage increases
if( sc && skill_num != LK_SPIRALPIERCE && skill_num != ML_SPIRALPIERCE )
{ //SC skill damages
if(sc->data[SC_AURABLADE])
ATK_ADD(20*sc->data[SC_AURABLADE]->val1);
}


Originally posted by calciumkid
What do you want me to check about them?

Mine are the same :3

   	 //Post skill/vit reduction damage increases
        if( sc && skill_num != LK_SPIRALPIERCE && skill_num != ML_SPIRALPIERCE )
        {    //SC skill damages
            if(sc->data[SC_AURABLADE])
                ATK_ADD(20*sc->data[SC_AURABLADE]->val1);
        }


Originally posted by calciumkid
Any updates on this?

Originally posted by CalciumKid
Bumpity boo :)

Originally posted by CalciumKid
prom said anyone else can fix this :)

Originally posted by Xantara
I think it is working as intended.

iRO Wiki:

This is almost a Weapon Mastery Skill, and thus almost carries those properties; for example, the damage gained from this skill bypasses defense, and is added at the end of all attacks.


Only the damage gained from the skill bypasses defense, not the whole attack damage....?

Originally posted by MarkZD
I'm testing on bRO.

Edited by MarkZD, 23 April 2012 - 07:53 PM.


Originally posted by MarkZD
Tested against a Bradium Golem and Ambernite with bash with and without aura blade.
No cards that add damage used.
Skill Bash from Swordman used.
Using a hunting spear+5.

Difference in damage is very low.
Ambernite(26 def):
From 1957 to 2187 without aura blade.
From 2189 to 2336 with aura blade.

Bradium Golem(358 def):
From 1641 to 1735 without aura blade.
From 1719 to 1898 with aura blade.


So, apparently only damage gained from skill bypasses defense.

Edited by MarkZD, 25 April 2012 - 01:17 PM.


Originally posted by Angezerus

So, I apparently only damage gained from skill bypasses defense.


Isn't that's how it should work?

This is almost a Weapon Mastery Skill, and thus almost carries those properties; for example, the damage gained from this skill bypasses defense, and is added at the end of all attacks.


That means to me that it is added after the skill's bonus.

Like:

200 overall atk when used with a 600% atk skill, and max aura blade on should be something like:

(200*6) + 100
(affected by def) + not affected by def

I think it is working as intended


Edited by Angezerus, 25 April 2012 - 08:51 AM.


Originally posted by adan-01
Hey, you should check again this skill, somehow it's not working anymore.. I have tested it and I deal the same damage, it's not adding the 100

moved issue from Skills