Issue Information
-
#005360
-
0 - None Assigned
-
Working as Intended
Issue Confirmations
-
Yes (0)No (0)
0
ea_job_system.txt and map.h: naming inconsitency
Posted by Hercules Bot on 20 February 2012 - 03:32 PM
Originally posted by Wildcard
/doc/ea_job_system.txt could also be updated to reflect the addition of third classes, but really, it's easy enough to figure it out own your own. What confused me a lot more is that the source refers to the "ea jobs"
EAJ_ as MAPID_
and "job levels"
EAJL_ as JOBL_
Opinions on whether we could unify those conventions, and if, which one should we choose?
/doc/ea_job_system.txt could also be updated to reflect the addition of third classes, but really, it's easy enough to figure it out own your own. What confused me a lot more is that the source refers to the "ea jobs"
EAJ_ as MAPID_
and "job levels"
EAJL_ as JOBL_
Opinions on whether we could unify those conventions, and if, which one should we choose?
Originally posted by Gepard
Script engine defines are in db/const.txt, so it actually is naming inconsistency between const.txt and map.h.
map.h defines are named this way because only map-server uses this convention. Char-server uses Gravity's numbering for player classes. So MAPID_X totally makes sense and is also self-explanatory ("id of the class X used internally by map-server"). I wouldn't change this.
I'm not sure about EAJ_. It still refers to eAthena, but it doesn't feel like a valid reason to rename it (and if it was to be renamed, we shouldn't just replace E with R). It is also used in several scripts: kafraExpress scripts (custom), novice guild warper (event) and two first class tutorial quests (official) and possibly in user-created scripts (possible compatibility break).
Script engine defines are in db/const.txt, so it actually is naming inconsistency between const.txt and map.h.
map.h defines are named this way because only map-server uses this convention. Char-server uses Gravity's numbering for player classes. So MAPID_X totally makes sense and is also self-explanatory ("id of the class X used internally by map-server"). I wouldn't change this.
I'm not sure about EAJ_. It still refers to eAthena, but it doesn't feel like a valid reason to rename it (and if it was to be renamed, we shouldn't just replace E with R). It is also used in several scripts: kafraExpress scripts (custom), novice guild warper (event) and two first class tutorial quests (official) and possibly in user-created scripts (possible compatibility break).
Originally posted by Mr. No One
Keeping the current version as a working alias would save you from breaking compatibility, yet giving you more space in customization and progress.
Keeping the current version as a working alias would save you from breaking compatibility, yet giving you more space in customization and progress.
Edited by Mr. No One, 05 March 2012 - 09:15 AM.
Originally posted by Akkarin
I'm setting this as Working as Intended, because there's no longer a documentation issue (fixed initial statement in [rev=16239]) and the rest doesn't need to be changed.
I'm setting this as Working as Intended, because there's no longer a documentation issue (fixed initial statement in [rev=16239]) and the rest doesn't need to be changed.
