Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #005404

  • 4 - High

  • Started

Issue Confirmations

  • Yes (10)No (0)
Photo

Atk calculation

Posted by Hercules Bot on 08 March 2012 - 03:04 AM

Originally posted by Poseid0n
Hello,

I don't know exactly where the error is, but something with the calculation of the attack seems wrong.

for example, card effects affect the entire atk instead juste affecting atk of the weapon. It's look the same for effects like "ice pick", or "Enchant Deadly Poison" who affecting entire attack.

For more explanation about how atk should works : http://irowiki.org/wiki/Atk

In case of assassin class, who can carry two weapon (left hand / right hand), effects of card are accumulated, and affect the entire atk. (So, you can easily get a guillotine cross with 150 percent increase in its total attack)

Poseidon

Originally posted by Poseid0n
Can someone confirm that card effect increase the total damages and not only the weapon damage ?

Originally posted by Poseid0n
I have founded more informations about this subject :

http://www.gathering...s#Weapon_Damage

All is explain, and confirm what I said preaviously.

Poseidon

Originally posted by Aleos
I can also confirm this. The effects of cards are being attached to the status too rather than just the weapon.

Edited by Aleos, 22 March 2012 - 01:28 PM.


Originally posted by Wildcard
I assume you are talking about renewal ATK here. The formula currently employed is indeed far from correct. Research on that subject is ongoing, but I expect it will be a while before we get it done.

Originally posted by Poseid0n
Up.

What about the progress on this change ? Do you have more information ?

This is a major change of Renewal and without it, many skills are not balanced. (Like Cross Inpact, Arrow Storm, Sacrifice, etc ... which inflict too much damage and disrupt the gameplay).

Poseidon

Originally posted by MarkZD
http://rathena.org/b...killing-stroke/
While looking for Final Strike sources I've found in bRO and iRO that this skill is not affected by racials card, just in the weapon atk.

Only Archer skeleton card would increase its final damage.

Archer Skel adds 10% of the final damage (eg 30k becomes 33k), as oppose to hydra which add 20% of weapon attack or zipper bear which just adds flat attack.

http://forums.irowik...hp/t-43756.html

Cartas raciais não contam para aumentar o dano de ataque mortal, o maximo que poderia ocorrer é aumentar o dano de ataque da arma contra humanoides o que nao seria perceptivel para o dano. Só para constar:

Racials card doesn't increase final strike damage, maybe it'd occur is the weapon damage would increase against the race, but it wouldn't be noticeable to the damage.
Just for knowing.
http://sites.levelup...91/4416814.aspx

Sim isso foi relatado no periodo beta da Renovação, as melhores opções são carta que deêm ataque como Andre, Zipper, Lobo, Zenorc e por enquanto a carta esqueleto arqueiro, que aumenta o dano total com base na % da carta.


It was noticed in the beta renewal period, the better options are cards that increase atk as Andre, Zipper, Wolf, Zenorc and for while Archer Skeleton Card which increase damage in the % base of the card.
http://ninjasiga.for...o-ataque-mortal

I think it's related to this report in any way as it shows racial cards add just to weapon damage, not tusre if it's just to Final Strike, but as it's said in this bug report it should be to all.

Edited by MarkZD, 21 April 2012 - 12:43 PM.


Originally posted by Angezerus
What's the status of this? Numerous skill and core issues are present because of this...

I post the quote here I posted in the mentioned issues. Hope it can help.

ATK = sATK * 2 + wATK + eATK + masteries



STATUS ATK = floor ( Base level / 4 + STR + DEX / 5 + LUK / 3)
  • Normally Neutral except when using Mild Wind.
  • Ignores element resistance effects such as Raydric Card or Asprika.
  • Ignores % ATK item effects such as The Sign or Hydra Card.
Weapon ATK = (Base Weapon ATK + Variance + STR + Bonus Refinement Bonus) * Size Penalty

Variance = ± 0.05 * Weapon Level * Base Weapon ATK

STR Bonus = Base Weapon ATK * STR/200

  • Affected by weapon element when using a melee weapon.
  • Affected by ammunition element when using a ranged weapon or specific skill.
  • Affected by element resistance effects such as Raydric Card or Asprika.
  • Increased by % ATK item effects such as The Sign or Hydra Card.
  • Multiplied by 5 when affected by Enchant Deadly Poison .
  • Though the STR bonus takes Element , it is still considered Neutral .
  • STR Bonus is always reduced by Ghost armor.
  • STR Bonus is only reduced by Neutral resistance like Raydric card, if the weapon is Neutral too.
  • Variance is a random number ranging from (-5% * Weapon Level * Base Weapon ATK) to (5% * Weapon Level * Base Weapon ATK)
Equipment ATK is the sum of ATK gained from equips other than weapons. Support buffs tend to increase this ATK, too, but not all of them fit into this category.
  • Affected by weapon element when using a melee weapon.
  • Affected by ammunition element when using a ranged weapon or specific skill.
  • Ammunition ATK is added here when using DEX based weapon.
  • Any +ATK you get from cards, including cards in weapon, is added here.
  • Affected by element resistance effects like Raydric Card or Asprika.
  • Increased by % ATK item effects like The Sign and Hydra Card.
  • Multiplied by 4 when affected by Enchant Deadly Poison.
Mastery ATK is a special kind of ATK that has no elemental properties. While most masteries come from Passive Skills , there are some Active Skills such as Camouflage or Zen.
  • Because masteries are not elemental, they are unaffected by Ghost armors or Raydric Cards.
  • Since masteries are direct increases to ATK, they are affected by skill modifiers, DEF and damage increasing/decreasing effects.



Originally posted by Smoke
I was just going through the code for this in status_base_atk and saw this :


#ifdef RENEWAL
		rstr =
#endif
		str = status->dex;
		dex = status->str;
	} else {
#ifdef RENEWAL
		rstr =
#endif
		str = status->str;
		dex = status->dex;

where str = status->dex;
      dex = status->str;

does this seem alright?

Originally posted by Angezerus

if (flag)


If "flag" means ranged (bow/instrument/whip/gun) attack, then this is the dex/str switching part. So it's okay. But still, rA doesn't use the fully renewal calculation, what is posted above. :(

I think this should be a high priority, because of the many bugs with attacks (and skills), just as I mentioned above.

Edited by Angezerus, 06 July 2012 - 01:02 PM.


Originally posted by Smoke
Yes I just referred to my coding and saw the same flag / weapon dex/str swtiching thing.

This is the current formula used by rA and I'm testing on my current svn compared to my character on iRO.
str = (rstr*10 + dex*10/5 + status->luk*10/3 + ((TBL_PC*)bl)->status.base_level*10/4)/10;
I'm not sure about rA's other status atk bonuses but this is accurate. I've got 124 batk on iRO and on my server.
Also it looks like they've removed the x2 crit bonus for katars, on iRO*.

Edited by Smoke, 06 July 2012 - 02:46 PM.


Originally posted by Angezerus

Yes I just referred to my coding and saw the same flag / weapon dex/str swtiching thing.This is the current formula used by rA and I'm testing on my current svn compared to my character on iRO.

str = (rstr*10 + dex*10/5 + status->luk*10/3 + ((TBL_PC*)bl)->status.base_level*10/4)/10;
I'm not sure about rA's other status atk bonuses but this is accurate. I've got 124 batk on iRO and on my server.Also it looks like they've removed the x2 crit bonus for katars.


Crit bonus is working for me.

Originally posted by Angezerus
Bump?

Originally posted by malufett
bumpy for Wildcard...any news/progress?? /no1

Originally posted by Wildcard
Pending the final word on the svn organization.. Research for melee and ranged physical damage largely done, thought lots and lots of rewriting and research on status effects and skill modifiers remain to be done.

Originally posted by Lighta
Well I think status_effect and skill_modifier will probably have there own report, most of them affecting dammage anyway, ATK_ADD, wd.dammage etc....
Now about atk formula and manipulation eatk is the main problem, since right now weapon and other equipement share the same bonus wich mean increase the same atk in the end wich shouldn't be the case.
(Ok that doesn't matter for calculating basic ATK as it's show in formula (since it's just a +) but will have issue altering those value separatly, like EDP for instance should increase wtak*4 and eatk*5
Masteries give elemental issue, since one again they all glue together.

Edited by Lighta, 17 July 2012 - 05:37 AM.


Originally posted by Angezerus
I see. Well, I hope we can use it soon :)

Originally posted by Nyx
Bump ~

Originally posted by Poseid0n
Up. Some News about this main update ?

Originally posted by Poseid0n
Up.

Originally posted by Angezerus
Bumper [====[]=======[]====]
(  â—Ù® ●(●ٮ ● (●ٮ ● )●ٮ ● )●ٮ ● )Ù® ●(●ٮ ● )Ù® ● )(●ٮ ●)

Is this gonna be implemented or is there someone working on it? Do you need info or help or something? Please, we really need this stuff :)