Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

Issue Confirmations

  • Yes (0)No (0)
Photo

Sage land skill buff icon (SI_LANDENDOW)

Posted by Hercules Bot on 14 March 2012 - 03:52 PM

Originally posted by Wildcard
I'm talking about the blue star buff icon currently used to indicate if you are under the effect of deludge, volcano or violent gale.
While working on status packet code, I noticed some striking differences in *Athena behaviour when compared to official servers.

*Athena:
  • any player standing on a tile affected by one of the three land skills receives the buff icon
  • leaving the tile or removing the land effect on it removes the icon
  • the buff icon has no time bar
official servers:
  • only the owner of the land skill receives the buff icon upon casting one of the three skills
  • other players don't receive an icon for standing on an affected tile
  • the icon does not disappear when leaving the area
  • in fact, it does not disappear even if you change maps(!)
  • it also does not disappear if all affected land tiles are removed (other player's land protector, ganbantein)
  • it is only removed upon death, when the 5 minute timer runs out or the player himself casts land protector
  • when casting a second land skill, the timer is refreshed, but no status end packet is sent
  • the duration of the buff icon is fixed to 5 minutes, even though the duration of the skills can be less than that
Clearly, the official implementation is rather.. broken. Loathe as I am to remove the current rAthena behaviour and replace it with something subjectively worse, official is official? What do you guys think?

Originally posted by xazax
I think we should not implement bugs.

And it is very obvious to me, it is buggy on official servers

.
16:53    Wildcard    opinions welcome: http://rathena.org/b...n-si-landendow/
16:57    xazax|work    IMO
16:57        --- xazax|work is back
16:57    xazax|work    we should not implement bugs on purpuse
16:58    Wildcard    well, my concern is more of the sort "we have a "feature" that official servers don't have at all
16:58    xazax|work    well
16:58    Wildcard    namely, a clientside indicator that tells you if you are on a land skill or not, even with effects off
16:58    xazax|work    I think this is the most logical behaviour
16:59    Wildcard    I agree, it's neat, but aegis doesn't seem to have it
16:59    xazax|work    the worst thing we should/can make is
16:59    xazax|work    to add a configuration for that
17:01    Wildcard    it's too minor for that
17:01    xazax|work    usually it is good to aviod custom features, because they cause bloat, or make big differences compared to official experience
17:01    xazax|work    I think this does not make any bloat nor change the experience greatly
17:01    xazax|work    but of course that is only my opinion, probably others will disagree



Originally posted by Rytech
You could release a experimental patch. Does rAthena have a patch area in the SVN?

Originally posted by Gepard
From the description, I'd say that Aegis meaning of the icon is different from rAthena's. In Aegis it looks like it's supposed to be an indicator for the caster only on how long is the effect in place. It is not meant to be an indicator of stepping into the AoE.

So I'd say, make it official by displaying the status icon to the caster only, and removing it when the skill duration runs out. But don't implement a bug (not removing the icon when expected).

Originally posted by Ind
I'm with xazax, I do not think we should implement bugs solely to mimic "official behavior".

From the description, I'd say that Aegis meaning of the icon is different from rAthena's. In Aegis it looks like it's supposed to be an indicator for the caster only on how long is the effect in place. It is not meant to be an indicator of stepping into the AoE.So I'd say, make it official by displaying the status icon to the caster only, and removing it when the skill duration runs out. But don't implement a bug (not removing the icon when expected).

the icon was present way before sc timers were displayed in the client.

Originally posted by Poseid0n
I don't understand ... why would you implement un bug, while there is plenty of bug on the other skills which are waiting since a long ?