Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #005514

  • 3 - Medium

  • Needs More Info

Issue Confirmations

  • Yes (1)No (0)
Photo

[Arch Bishop] Sacrament

Posted by Hercules Bot on 27 March 2012 - 11:25 AM

Originally posted by Joseph
Doesn't reduce casting time.

iRO Wiki:

This skill decreases the target's fixed cast time by 10~50%.

http://irowiki.org/wiki/Sacrament

Originally posted by Lilith
src/map/skill.c


#if RECASTING
if( sc->data[SC__LAZINESS] )
fixed += fixed * sc->data[SC__LAZINESS]->val2 / 100;
/**
* AB Sacrament reduces fixed cast time by (10 x Level)% (up to 50%)
**/
if( sc->data[SC_SECRAMENT] )
fixed -= fixed * sc->data[SC_SECRAMENT]->val2 / 100;
#endif


Edited by Lilith, 27 March 2012 - 03:45 PM.


Originally posted by Ind
Make sure you have /src/map/config/Renewal.h "RECASTING" enabled.

Originally posted by Traxis
It doesn't work at all, really. I've tested it with many skills (RECASTING enabled of course), and it doesn't reduce the casting time, even a little. I know it should reduce just the Fixed Cast Time, but it's like you don't have effect or something (I see the icon, and that's it).

Could someone else try it?

Originally posted by Joseph

Make sure you have /src/map/config/Renewal.h "RECASTING" enabled.


Enabled, and it is still the same.

Originally posted by Ind
I added debug lines before and after sacrament modifier is applied. it works. Just to make sure I even changed the fixed cast time to a higher value so that its easily noticeable, added 10s fixed cast time to Zen (soul collect) during my tests, and while in sacramento the cast time went down by 50% (lv 5) to 5s.

Originally posted by Traxis
Could you test it with Oratio? I don't see the difference at all. It should reduce the cast time "greatly".

Originally posted by Ind
I see where the problem lies. Thanks for the scenario Traxis.

Originally posted by Ind
Need to know how official servers behave in this case: (thanks to Traxis for Oratio test case)
- Notice my exemple isn't taking DEX/INT into account.
- Oratio has 5s variable cast time and no fixed cast time, so it gets 20% fixed cast time (20% of 5s) which turns to be 1s.
- If cast with sacrament status lv 5, fixed cast time is reduced to 0.5s.
- Upon finalizing the math the server currently applies a max(variable,fixed) which returns the greater of both, which leads to variable cast time taking priority against fixed cast time.
How is this meant to be applicable? It means that when your variable cast time is greather than your fixed cast time the variable cast time takes priority. is the server meant to SUM them?

Originally posted by Ind
bump.

Originally posted by Hamza221
Oratio on Iro has 1sec fixed cast and 4s of variable cast time that is total 5 seconds of casttime.

After secrament casted the should be around 2secs i guess not sure... and fixed cast time goes down to 0.5secs..

And both the cast times are getting sumed up on iro which results casting orioto to around 2.5sec to 3 sec cast time will calculate and let u know..

hope this helps

Edited by Hamza221, 15 June 2012 - 10:21 AM.


Originally posted by MarkZD

Oratio

Success Chance: (40 + 5 * Skill Level) %
Holy Element resistance reduction: (2 * Skill Level) %
Fixed Cast Time: 1 second
Variable Cast Time: 4 seconds
Skill re-use Delay: 2 seconds
Global Skill Delay: None

All skills should be updated:
http://rathena.org/b...ebalancing-kro/
Some of them were updated recently.

There're other posts with updates.
There's no more 20% fixed cast to everything, it was already clarified.

If I'm not wrong Rytech is apart of it and can give more informations.

Oratio on Iro has 1sec fixed cast and 4s of variable cast time that is total 5 seconds of casttime.After secrament casted the should be around 2secs i guess not sure... and fixed cast time goes down to 0.5secs..And both the cast times are getting sumed up on iro which results casting orioto to around 2.5sec to 3 sec cast time will calculate and let u know..hope this helps

I think there's some error here. Oratio reduces "Fixed" cast time, but by the way you say the cast went to 2sec, so it reduced variable too?
I think you're taking into account your Dex and Int.

The question is just one, does fixed sum with variable cast time?
If you're right, yes.

Edited by MarkZD, 15 June 2012 - 06:04 PM.


Originally posted by Hamza221
yes both did sum up on iro... i checked with a timmer P without sacra it went to 5secs and with secra it was around 3secs