Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #005745

  • 1 - Low

  • Fixed

Issue Confirmations

  • Yes (5)No (0)
Photo

Recognized Spell

Posted by Hercules Bot on 14 May 2012 - 04:04 PM

Originally posted by Judas
Is Recognized Spell implemented in rA yet? It doesn't seem to change damage

Originally posted by malufett
oh..yeah its not yet fully implemented..only the sp consumption part...

Originally posted by Aleos
Is there any information on how the skill is supposed to work? The description seems kinda vague.

Originally posted by unknown267
The skill description says it makes all spells do max damage, so it's like a magical Maximize Power. Don't see how that's vague O.o

Originally posted by Aleos
Hm. Ok so it's setting the min = max. Ok now I understand it, I totally forgot Maximize Power acted the same way. I was thinking of it in a different method which is what was confusing me.

Originally posted by esu1214
find
   #ifdef RENEWAL //Renewal MATK Appliance according to doddler (?title=Renewal_Changes#Upgrade_MATK)
	/**
	 * min: (weaponMATK+upgradeMATK) * 2 + 1.5 * statusMATK
	 * max: [weaponMATK+upgradeMATK+(wMatk*wLvl)/10] * 2 + 1.5 * statusMATK
	 * yes this formula MATCHES their site: matk_max already holds weaponmatk+upgradematk, and
	 * -> statusMATK holds the %Matk modifier stuff from earlier and lastly:
	 * -> the mdef part is not applied at this point, but later.
	 **/ //1:bugreport:5101				 //1:bugreport:5101
	MATK_ADD((1+sstatus->matk_max) * 2 + 15/10 * sstatus->matk_min + rnd()% ( sstatus->matk_max + (1 + (sstatus->matk_max*sstatus->wlv) / 10 * 2 + 10/15 * sstatus->matk_min ) ));
   #else //Ancient MATK Appliance
	if (sstatus->matk_max > sstatus->matk_min) {
	 MATK_ADD(sstatus->matk_min+rnd()%(1+sstatus->matk_max-sstatus->matk_min));
	} else {
	 MATK_ADD(sstatus->matk_min);
	}
   #endif
replace
MATK_ADD((1+sstatus->matk_max) * 2 + 15/10 * sstatus->matk_min + rnd()% ( sstatus->matk_max + (1 + (sstatus->matk_max*sstatus->wlv) / 10 * 2 + 10/15 * sstatus->matk_min ) ));
to
	if(sc && sc->data[SC_RECOGNIZEDSPELL])
	 MATK_ADD(sstatus->matk_max);
	else
	 MATK_ADD((1+sstatus->matk_max) * 2 + 15/10 * sstatus->matk_min + rnd()% ( sstatus->matk_max + (1 + (sstatus->matk_max*sstatus->wlv) / 10 * 2 + 10/15 * sstatus->matk_min ) ));


Originally posted by MarkZD
esu1214, your formula is VERY wrong, as any value you use in your formula with RECOGNIZED SPELL will be lower than without it.

Recognized Spell should add the MAX damage.
You just have to remove rnd()%, so it'll be the max damage.

if(sc && sc->data[SC_RECOGNIZEDSPELL])
  MATK_ADD((1+sstatus->matk_max) * 2 + 15/10 * sstatus->matk_min + ( sstatus->matk_max + (1 + (sstatus->matk_max*sstatus->wlv) / 10 * 2 + 10/15 * sstatus->matk_min ) ));
else
  MATK_ADD((1+sstatus->matk_max) * 2 + 15/10 * sstatus->matk_min + rnd()% ( sstatus->matk_max + (1 + (sstatus->matk_max*sstatus->wlv) / 10 * 2 + 10/15 * sstatus->matk_min ) ));

Edited by MarkZD, 12 November 2012 - 01:49 AM.


Originally posted by malufett
ok..I'm with it..

:meow:

Originally posted by malufett
Fixed @ [rev='16981']

:meow:

moved issue from Skills