Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #005790

  • 0 - None Assigned

  • Fixed

Issue Confirmations

  • Yes (3)No (0)
Photo

Genetic item from special pharmacy

Posted by Hercules Bot on 22 May 2012 - 06:56 PM

Originally posted by michieru
Genetic item from special pharmacy a wrong they should do:

Enriched White PotionZ Recover 1000 HP (fixed value, stats dont matter), Increase HP's natural recovery rate by 20%, 500 seconds duration.
Vitata500 Increases SP by +5%, Increase SP's natural recovery rate by 20%, 500 seconds duration. Recover 200 SP (fixed)
Enrich Celermine Juice Increases attack speed by 10% (Stacks with other aspd potions), 500 seconds duration.
Cure Free Recover from a variety of abnormal conditions (Silence, Bleeding, Curse, Poison, Undead). Recover 500 HP (fixed)
Increase HP Potion (Small) Increases max HP by (500 + 10 / 3 * BaseLevel), 2% HP recovery. 500 seconds duration.
Increase HP Potion (Medium) Increases max HP by (1500 + 10 / 3 * BaseLevel), 3% HP recovery. 500 seconds duration.
Increase HP Potion (Large) Increases max HP by (2500 + 10 / 3 * BaseLevel), 5% HP recovery. 500 seconds duration.
Increase SP Potion (Small) Increases max SP by (-5 + BaseLevel/10)%, SP recovery 2%. 500 seconds duration.
Increase SP Potion (Medium) Increases max SP by (BaseLevel/10)%, SP recovery 4%. 500 seconds duration.
Increase SP Potion (Large) Increases max SP by (5 + BaseLevel/10)%, SP recovery 8%. 500 seconds duration.


Source: http://irowiki.org/w...pecial_Pharmacy

When it's said fix it's fix no vit int bonus. Tested on iRo.

Originally posted by michieru
bump

Originally posted by Vali
+1the scripts are not correct.

Originally posted by Kenpachi
Can't fix Enrich Celermine Juice (#12437) because there is no status that could be used. (Must be able to stack with other ASPD potions.)

Can't fix Increase HP/SP Potions (#12422-#12427) because there is no status that could be used. (Must increase HP/SP by a fixed value.)

Everything else was fixed in [rev=16250].


Moving this to the Core section to make a core developer create the missing statuses.

Originally posted by michieru
Any news?

Originally posted by Lighta
Actually Enriched White PotionZ will still benefit vit bonus from the precedent change so it's not fixed for me :
You should use heal insteand itemheal to get a real fixed heal amount.
About your maxhp maxsp issue with a fixed value : bMaxHP and bMaxSP will do the job :

case SP_MAXSP:
        if(sd->state.lr_flag == 2)
            break;
        val += (int)status->max_sp;
        status->max_sp = (unsigned int)val;
        break;



Originally posted by Kenpachi
BUMP!

Originally posted by malufett

Can't fix Enrich Celermine Juice (#12437) because there is no status that could be used. (Must be able to stack with other ASPD potions.)

it already defined... use 'SC_EXTRACT_SALAMINE_JUICE' and val1 holds the total aspd bonus....n% = 100%

Originally posted by Kenpachi
Additionally Cookie showed me that in [rev=15599] SC_INCASPDRATE was re-enabled.
Does SC_EXTRACT_SALAMINE_JUICE stack with SC_ASPDPOTION0-3, too?

So I just need a status change that increases/decreases the users HP/SP by a fixed amount.

Originally posted by malufett

Additionally Cookie showed me that in r15599 SC_INCASPDRATE was re-enabled.
Does SC_EXTRACT_SALAMINE_JUICE stack with SC_ASPDPOTION0-3, too?

in iRO and Aegis it stack with potions but I don't know with kRO I can't check ATM since some of the players don't want to give me some..XD
IMO it is better to use 'SC_EXTRACT_SALAMINE_JUICE' because it uses 'SI_EXTRACT_SALAMINE_JUICE' even though it shows nothing in the client...

Originally posted by Cookie
Added SC_INCMHP and SC_INCMSP for fixed amounts. Updated the SQL files and text driven item_db files in the /db/. Please refer to the latest revision [rev=16454].

Originally posted by Kenpachi
You forgot item #12437, Cookie. ;)

Originally posted by xazax
Wouldn't something like autobonus which is scriptable be more flexible?

I think we should extend autobonus functionality and remove some statuses.

Originally posted by malufett
auto bonus? something like? :)

Originally posted by Kenpachi
autobonus works with rates/triggers but I needed a permanent change/bonus.

Originally posted by Kenpachi
Fixed in [rev=16466].