Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

• Issue ID

  #005886

• Severity

  2 - Fair

• Status

  Confirmed

Issue Confirmations

• Yes (1)No (0)

0

Changeset 16183 - instance problem

Posted by Hercules Bot on 01 June 2012 - 08:53 AM

Originally posted by saithis
In npc.c the instances get now destroyed after @reloadscript, and a line after that it tries to reinitialize them:

do_final_instance();

for( i = 0; i < ARRAYLENGTH(instance); ++i )
instance_init(instance[i].instance_id);

Also some scripts supported reinitialization after @reloadscript, this scripts are now broken.
For example my ET script just restarted the last stage they were on.

So wouldn't it be better to rewrite the instance scripts to support reinitialization instead of removing this feature for all scripts?

• Back to top

Hercules Bot

Jun 01 2012 11:51 AM

Originally posted by Ind
thank you for the suggestion -- the bug tracker isn't for suggestions though. but i wrote a topic for you here :3 http://rathena.org/b...o-reloadscript/ (i believe this doesn't count as a bug report because the official instance scripts rathena provides all break in reloadscript)

• Back to top

Hercules Bot

Jun 01 2012 02:56 PM

Originally posted by saithis
i tought is is a bug, because the new code tries to reinitialize the instance, after destroying it
maybe it doesn't break the code(didn't test what happens there), but it's definitelly not the right thing^^
But thanks for making the suggestion topic

• Back to top

Hercules Bot

Jun 01 2012 03:22 PM

Originally posted by Ind
whops sorry you're right.

• Back to top

1. Bug Tracker
2. → Core
3. → Severity: Fair
4. → Status: Confirmed
5. Privacy Policy
6. Hercules Forum Rules ·