Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #005933

  • 3 - Medium

  • Fixed

Issue Confirmations

  • Yes (0)No (0)
Photo

Vending Check[2]

Posted by Hercules Bot on 04 June 2012 - 04:13 PM

Originally posted by EvilPuncker
the problem that I described in this post still happening with your code

http://rathena.org/b...rotection-area/



1 - go near a npc and try to open your store
2 - get the msg
3 - walk away from the npc range
4 - click ok to sell the same item
5 - get "You can't sell undentified items"



also seems like on official RO you are not able to walk while you are on pre-vending state, but on rA you are.

Originally posted by malufett
what problem??
can you quote it here please..Thanks...^^

Originally posted by EvilPuncker
added

Edited by EvilPuncker, 04 June 2012 - 04:41 PM.


Originally posted by malufett
Confirmed!

in IRO
can't walk/move when in pre-vending state.
can use vending skill beside npc but nothing will appear/happens no skill fail message or warning message...

Originally posted by EvilPuncker
any progress on this? kinda of annoying :(

Originally posted by Ind
the problem with this bug is that, so far, we don't know how the client tells the server that one has closed the vending state. so we can't mimic the feature yet

Originally posted by EvilPuncker
can't at least fix the walking part? so we can't walk while in pre-vending state

Originally posted by nanakiwurtz
I add this line at skill.c:
sd->state.prevend = 1;
clif_openvendingreq(sd,2+skilllv);
sc_start(bl, SC_STOP, 100, 1, 10000);
It will stop your char for 10 seconds, but currently I don't know how to cancel it.
I have tried to capture the flag=0 at vending.c
if( !flag ) {
status_change_end(&sd->bl, SC_STOP, INVALID_TIMER);
return;
}
But it still won't cancel the SC_STOP effect.

Originally posted by Emistry
@Evilpunker / nankiwurtz
i think you can try use this to prevent the character from walking...
sd->state.blockedmove = 1;


Originally posted by nanakiwurtz
Thanks for the code Emistry, but how to cancel it?
I've tried to put these lines in vending.c
void vending_openvending
//....
if( !flag ) {
sd->state.blockedmove = 0;
return;
}
It can't make the char walkable again, or maybe I edit wrong file

Originally posted by malufett
@nanakiwurtz
that is why we flag it Needs more info..cause we are looking for clients that will work with this feature..since most of it doesn't send a packet when it closes the window..anyway I'm still checking if this is existing in kRO..

:meow:

Originally posted by EvilPuncker
the problem that I described in this post still happening with your code

[url="[url="http://rathena.org/board/topic/63003-7x7-vend-protection-area/%22%5D"]http://rathena.org/b...rotection-area/"][/url]http://rathena.org/b...rotection-area/[/url]



1 - go near a npc and try to open your store
2 - get the msg
3 - walk away from the npc range
4 - click ok to sell the same item
5 - get "You can't sell undentified items"


also seems like on official RO you are not able to walk while you are on pre-vending state, but on rA you are.

In latest hercules, on pre-vending state we cant move. Already fixed i think.

Edited by kyeme, 09 March 2013 - 03:35 AM.


changed status to: Fixed

oh I forgot this report..hahaha..

thanks for reminding..

:meow: