Issue Information
-
#005935
-
0 - None Assigned
-
Fixed
Issue Confirmations
-
Yes (1)No (0)
0
Originally posted by jTynne
Per official description, supposed to give Level 1 Double Attack, but currently uses doubleattack bonus:
REPLACE INTO `item_db` VALUES (4117,'Side_Winder_Card','Sidewinder Card',6,20,NULL,10,NULL,NULL,NULL,NULL,NULL,NULL,NULL,2,NULL,NULL,NULL,NULL,'bonus bDoubleRate,5;',NULL,NULL);
Fix:
REPLACE INTO `item_db` VALUES (4117,'Side_Winder_Card','Sidewinder Card',6,20,NULL,10,NULL,NULL,NULL,NULL,NULL,NULL,NULL,2,NULL,NULL,NULL,NULL,'skill \"TF_DOUBLE\", 1;',NULL,NULL);
Per official description, supposed to give Level 1 Double Attack, but currently uses doubleattack bonus:
REPLACE INTO `item_db` VALUES (4117,'Side_Winder_Card','Sidewinder Card',6,20,NULL,10,NULL,NULL,NULL,NULL,NULL,NULL,NULL,2,NULL,NULL,NULL,NULL,'bonus bDoubleRate,5;',NULL,NULL);
Fix:
REPLACE INTO `item_db` VALUES (4117,'Side_Winder_Card','Sidewinder Card',6,20,NULL,10,NULL,NULL,NULL,NULL,NULL,NULL,NULL,2,NULL,NULL,NULL,NULL,'skill \"TF_DOUBLE\", 1;',NULL,NULL);
Originally posted by ForteXX
It gives level 1 Double Attack to all weapon types, which just having the skill doesnt do, so it had to be faked to make it work with all items.
Though... it apparently is supposed to give a higher level of you have it, so perhaps it should be something like bonus bDoubleRate,5+5*getskilllv(\"TF_DOUBLE\)-1; <-- messy -.-
Thats going by iROwiki's Double Attack page, note at the bottom. 'All items that give double attack will work with all weapons, and will use a higher level, if that level is learned.'
It gives level 1 Double Attack to all weapon types, which just having the skill doesnt do, so it had to be faked to make it work with all items.
Though... it apparently is supposed to give a higher level of you have it, so perhaps it should be something like bonus bDoubleRate,5+5*getskilllv(\"TF_DOUBLE\)-1; <-- messy -.-
Thats going by iROwiki's Double Attack page, note at the bottom. 'All items that give double attack will work with all weapons, and will use a higher level, if that level is learned.'
Edited by ForteXX, 05 June 2012 - 12:30 AM.
Originally posted by Kenpachi
Fixed in [rev=16249].
Fixed in [rev=16249].
Originally posted by Daegaladh
This is wrong. It's true it should give TF_DOUBLE skill, but the bDoubleRate bonus should be left there too, because it makes the effect works on the rest of weapon types.
This is wrong. It's true it should give TF_DOUBLE skill, but the bDoubleRate bonus should be left there too, because it makes the effect works on the rest of weapon types.
Originally posted by Kenpachi
If it's true that TF_DOUBLE in rAthena doesn't work with all weapon types then I should move this bug to the Skill section...
If it's true that TF_DOUBLE in rAthena doesn't work with all weapon types then I should move this bug to the Skill section...
Originally posted by Daegaladh
But TF_DOUBLE only should work on all weapons when you have one of those items. For the normal Thief skill only works with daggers.
The way to do it is making a new bonus to add on those items for making the skill works on all weapons, but... wait! that's what bDoubleRate actually does! XD
But TF_DOUBLE only should work on all weapons when you have one of those items. For the normal Thief skill only works with daggers.
The way to do it is making a new bonus to add on those items for making the skill works on all weapons, but... wait! that's what bDoubleRate actually does! XD
Originally posted by frenzmu06
how about make bDoubleRate add a faked out TF_DOUBLE on skill tab (just show a skill icon but not necessary work)
how about make bDoubleRate add a faked out TF_DOUBLE on skill tab (just show a skill icon but not necessary work)
Originally posted by Daegaladh
bDoubleRate actually overwrites the effect of TF_DOUBLE. But yes, a possible better solution is making bDoubleRate to add TF_DOUBLE skill to the skill list. Or simply use the two bonuses together as I said.
bDoubleRate actually overwrites the effect of TF_DOUBLE. But yes, a possible better solution is making bDoubleRate to add TF_DOUBLE skill to the skill list. Or simply use the two bonuses together as I said.
Originally posted by Kenpachi
The official script gives the skill - nothing more regarding that effect.
So either the skill works with all weapon types (which is obviously wrong) or an item which grants that skill has the same effect as having the skill when being Thief.
In my opinion it's correct now.
The official script gives the skill - nothing more regarding that effect.
So either the skill works with all weapon types (which is obviously wrong) or an item which grants that skill has the same effect as having the skill when being Thief.
In my opinion it's correct now.
Originally posted by Daegaladh
Nope, I tested it some time ago on kRO, the skill only works with daggers, and items with TF_DOUBLE works on all weapons.
Nope, I tested it some time ago on kRO, the skill only works with daggers, and items with TF_DOUBLE works on all weapons.
Originally posted by Kenpachi
Okay. I trust you, Daegaladh.
I that case we should create a new skill that does the same as TF_DOUBLE but for all ewapon types.
Should be the easiest way to have a clean solution. (All effects with skill icon.)
Okay. I trust you, Daegaladh.
I that case we should create a new skill that does the same as TF_DOUBLE but for all ewapon types.
Should be the easiest way to have a clean solution. (All effects with skill icon.)
Originally posted by malufett
yes I also confirmed that in kRO....
hmm...what if we still use the bonus script then add the skill TF_DOUBLE... at least less coding...
and as the code says no matter what you have the skill TF_DOUBLE you can still use double attack in any weapon if you use the script bonus...
we will just add it in the documentation or if you wish to change its name to be appropriate that it will applicable in enabling double attack in any weapon...
yes I also confirmed that in kRO....
hmm...what if we still use the bonus script then add the skill TF_DOUBLE... at least less coding...
and as the code says no matter what you have the skill TF_DOUBLE you can still use double attack in any weapon if you use the script bonus...
we will just add it in the documentation or if you wish to change its name to be appropriate that it will applicable in enabling double attack in any weapon...
if( sd && !skill_num ) { //Check for double attack.
if( ( ( skill_lv = pc_checkskill(sd,TF_DOUBLE) ) > 0 && sd->weapontype1 == W_DAGGER )
|| ( sd->double_rate > 0 && sd->weapontype1 != W_FIST ) ) //Will fail bare-handed
{ //Success chance is not added, the higher one is used [Skotlex]
if( rnd()%100 < ( 5*skill_lv > sd->double_rate ? 5*skill_lv : sd->double_rate ) )
{
wd.div_ = skill_get_num(TF_DOUBLE,skill_lv?skill_lv:1);
wd.type = 0x08;
}
}
Originally posted by Kenpachi
Okay. That's a solution I can live with. I thought that it would stack the effect of DoubleRate if the item grants the skill and the status change.
I'll change this soon.
Okay. That's a solution I can live with. I thought that it would stack the effect of DoubleRate if the item grants the skill and the status change.
I'll change this soon.
Originally posted by Kenpachi
Fixed in [rev=16266].
Fixed in [rev=16266].
