Issue Information
-
#005972
-
0 - None Assigned
-
Fixed
Issue Confirmations
-
Yes (1)No (1)
0
Originally posted by frenzmu06
in doc/item_bonus
some bonuses state that you cant set variables for "n" but they are functional(description error)
ex.
bonus bNoMagicDamage,n; | n is meaningless)
idk if these scripts has also no functional "n", pls check
bonus bNoWeaponDamage,n;
bonus bRestartFullRecover,n;
bonus bNoSizeFix,n;
in doc/item_bonus
some bonuses state that you cant set variables for "n" but they are functional(description error)
ex.
bonus bNoMagicDamage,n; | n is meaningless)
idk if these scripts has also no functional "n", pls check
bonus bNoWeaponDamage,n;
Originally posted by Kenpachi
Where is the bug?
Where is the bug?
Originally posted by frenzmu06
pls. analyze the sentence -> the doc states wrong description
pls. analyze the sentence -> the doc states wrong description
Originally posted by Kenpachi
There's nothing wrong. "n is meaningless" means that you can put every integer value you want.
There's nothing wrong. "n is meaningless" means that you can put every integer value you want.
Originally posted by frenzmu06
to think:
bonus bNoMagicDamage,n;
bonus bNoMagicDamage,100; ->100 magic redux
bonus bNoMagicDamage,50; -> makes 50% magic redux
putting a variable in "n" gives different effect (so is "n" meaningless?)
while
bonus bNoCastCancel,n;
bonus bNoCastCancel,50; ->same effect as putting any #
bonus bNoCastCancel,100; ->same effect as any putting #
Note: this two has a description saying "n is meaningless"
so i'm saying that SOME has non-meaningless "n" which is documented on wrong and giving wrong info about "the specific bonus script"
but wont take any effect/difference on the bonus output, that's what your saying right?"n is meaningless" means that you can put every integer value you want.
to think:
bonus bNoMagicDamage,n;
bonus bNoMagicDamage,100; ->100 magic redux
bonus bNoMagicDamage,50; -> makes 50% magic redux
putting a variable in "n" gives different effect (so is "n" meaningless?)
while
bonus bNoCastCancel,n;
bonus bNoCastCancel,50; ->same effect as putting any #
bonus bNoCastCancel,100; ->same effect as any putting #
Note: this two has a description saying "n is meaningless"
so i'm saying that SOME has non-meaningless "n" which is documented on wrong and giving wrong info about "the specific bonus script"
Originally posted by frenzmu06
already tested most and applies only on
bonus bNoMagicDamage,n;
bonus bNoWeaponDamage,n;
variables on their "n" are not meaningless and applies % reduction depending on the # given
already tested most and applies only on
bonus bNoMagicDamage,n;
bonus bNoWeaponDamage,n;
variables on their "n" are not meaningless and applies % reduction depending on the # given
Originally posted by Kenpachi
Okay, now I understand.
I think a core dev should check this and update the documentation accordingly.
Okay, now I understand.
I think a core dev should check this and update the documentation accordingly.
Originally posted by Kenpachi
Fixed in [rev=16468].
I checked all bonuses with comment "n is meaningless" and those two were the only one with wrong documentation.
Fixed in [rev=16468].
I checked all bonuses with comment "n is meaningless" and those two were the only one with wrong documentation.
Originally posted by Mysterious
So, even doing:
bonus bNoWeaponDamage,50; won't reduce the damage by 5%? Because you just switched it to: Prevents from receiving n% physical damage (n is meaningless)
So, even doing:
bonus bNoWeaponDamage,50; won't reduce the damage by 5%? Because you just switched it to: Prevents from receiving n% physical damage (n is meaningless)
Originally posted by Kenpachi
I did not test it but:
I did not test it but:
case SP_NO_WEAPON_DAMAGE: if(sd->state.lr_flag == 2) break; val+= sd->special_state.no_weapon_damage; sd->special_state.no_weapon_damage = cap_value(val,0,100); break;... the value is capped between 0 and 100. So if 50 is passed the damage will be reduced by 50%.
Originally posted by EvilPuncker
you forgot to remove the "n is meaningless comment" in both lines and wtf you changed mmo.h to 20110315 without even saying a word about?
you forgot to remove the "n is meaningless comment" in both lines and wtf you changed mmo.h to 20110315 without even saying a word about?
Originally posted by Kenpachi
Damn, sorry it was ~3:00 AM in Germany and I simply was tired and overlooked that. Will be fixed ASAP.
Damn, sorry it was ~3:00 AM in Germany and I simply was tired and overlooked that. Will be fixed ASAP.
Originally posted by Kenpachi
Fixed in [rev=16474].
Fixed in [rev=16474].
