Issue Information
-
#006001
-
0 - None Assigned
-
Fixed
Issue Confirmations
-
Yes (0)No (0)
0
item 18600 item description table
18600#
a cute beret that feels cat is wearing it because of its ear decoration.
ATK + 5%.
If it refined over 5, will give 1% bonus on physical attack to "Human" type and receive less damage from "Human" type.
(This bonus would work up to +12, 7%)
Class : ^777777Headgear^000000 Defense : ^7777775^000000
Location : ^777777Upper ^000000Weight : ^77777730^000000
Required Lv. : ^7777771^000000
Applicable Job : ^777777 Every Job^000000
#
and the script
18600,Cat_Ear_Beret,Cat Ear Beret,5,20,,100,,5,,0,0xFFFFFFFF,7,2,256,,0,1,761,{ if(getrefine() > 5 && getrefine() <= 12) { bonus2 bAddRace,RC_DemiHuman,2*(getrefine() - 4); bonus2 bSubRace,RC_DemiHuman,2*(getrefine() - 4); }},{},{}
if refine to +5 will not receive bonus point
but if look into the script, item will give 2 point bonus.
and for +12 will give 16 point bonus
I thinks the script suppose to be like this
18600,Cat_Ear_Beret,Cat Ear Beret,5,20,,100,,5,,0,0xFFFFFFFF,7,2,256,,0,1,761,{ if(getrefine() > 5 && getrefine() <= 12) { bonus2 bAddRace,RC_DemiHuman,1*(getrefine() - 5); bonus2 bSubRace,RC_DemiHuman,1*(getrefine() - 5); }},{},{}
for item 18597
18597#
...
Aspd +3%, Critical +3
If refined to +7 or higher, Aspd +2% and Critical +2.
If refined to +9 or higher, Aspd +2% and Critical +2.
Class : ^777777Headgear^000000
Defense : ^77777710^000000
Location : ^777777Upper^000000
Weight : ^77777740^000000
Required Level : ^77777770^000000
Applicable Job :^777777 Every Job^000000
#
item script
18597,Mercury_Riser,Mercury Riser,5,40,,200,,10,,1,0xFFFFFFFF,7,2,256,,0,,759,{ bonus bAspdRate,3; bonus bCritical,3; if(getrefine() == 7 || getrefine() == 8) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,2; bonus bCritical,2; }},{},{}
For refine +7 and +8 will recieve 2 point for aspd and critical
and refine +9 or higher recieve 2 point more, is this mean player will recieve 4 point or same with refine +7, just recieve 2 point for upgrade the item.
will be simple if the script like this
18597,Mercury_Riser,Mercury Riser,5,40,,200,,10,,1,0xFFFFFFFF,7,2,256,,0,,759,{ bonus bAspdRate,3; bonus bCritical,3; if(getrefine() >= 7 ) { bonus bAspdRate,2; bonus bCritical,2; }},{},{}
i think this is will be same efect
I fixed it already, it works as it should work now.
ok thanks. i'm already testing on it
not update in sql?
Im thinking the script should continue working past +12, but stop increasing at that point, not stop working altogether (see other scripts with these kind of effects) [beret]
for the other, why wouldnt you use { bonus bAspdRate,3; bonus bCritical,3; if(getrefine() >= 7) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,2; bonus bCritical,2; }}
(more directly in line with what the description says)
Edited by ForteXX, 13 June 2012 - 02:25 PM.
ForteXX idea is better...
@Flaid
if(getrefine() == 7 || getrefine() == 8)
Well, it would, due to the next part in the script. Way it is right now, if +7 or +8, it gives 2, if +9 or greater, it gives 4.
I was just saying that the description says +7 or greater gives +2, +9 or greater gives another 2, not cancelling the +7/8 bonus and giving a straight 4.
Edited by ForteXX, 13 June 2012 - 03:50 PM.
Well, it would, due to the next part in the script. Way it is right now, if +7 or +8, it gives 2, if +9 or greater, it gives 4.I was just saying that the description says +7 or greater gives +2, +9 or greater gives another 2, not cancelling the +7/8 bonus and giving a straight 4.
you mean this script
{ bonus bAspdRate,3; bonus bCritical,3; if(getrefine() >= 7 ) { bonus bAspdRate,2; bonus bCritical,2; }},{},{}
will give +2 point at refine +7 or +8
and add +2 more for refine higher than +9
so character totaly receive 4 point if refine higher than +9
If you use that script, you will only ever be able to get a bonus of 5 (3+2) since it doesnt even have the refined to 9+ bonus
so let me make the table
+7 player get 5 point for aspd and critical
+8 player get same as refine +7
+9 player get 7 point for aspd and critical
+10 player get same as refine +9
is it right for this script
{ bonus bAspdRate,3; bonus bCritical,3; if(getrefine() >= 7 ) { bonus bAspdRate,2; bonus bCritical,2; }},{},{}
No, that script has nothing happening extra for +9 or greater, only the extra +2 for +7 or greater.
Using
{ bonus bAspdRate,3; bonus bCritical,3; if(getrefine() >= 7) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,2; bonus bCritical,2; }}
you get +3 of both all the time, at +7 or greater you get and additional +2 to each (+5 total), and at +9 or greater you get an additional +2 on top of that (+7 total)
^ which is exactly what
Aspd +3%, Critical +3
If refined to +7 or higher, Aspd +2% and Critical +2.
If refined to +9 or higher, Aspd +2% and Critical +2.
would be.
i'm already testing, i want to know the right script
if curently my critical and aspd is 43, 183 when equip the item become 46 critical point and 186 aspd point
when i'm equip this item at refine +7 my char will have 48 critical point and 188 aspd point
and when refine into +9 my char still got a same point
18597,Mercury_Riser,Mercury Riser,5,40,,200,,10,,1,0xFFFFFFFF,7,2,256,,0,,759,{ bonus bAspdRate,3; bonus bCritical,3; if(getrefine() == 7 || getrefine() == 8) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,2; bonus bCritical,2; }},{},{}
or will receive 50 critical point and 190 aspd point.
18597,Mercury_Riser,Mercury Riser,5,40,,200,,10,,1,0xFFFFFFFF,7,2,256,,0,,759,{ bonus bAspdRate,3; bonus bCritical,3; if(getrefine() == 7 || getrefine() == 8) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,4; bonus bCritical,4; }},{},{}
this is the result i'm already tested at my server
Thats because using the first script, you only get +2 at refined to 9+, since the first upgrade bonus is only applied at +7 and +8 (getrefine() == 7 || getrefine() == 8), and not at anything higher. The second one gives +2 only at +7 and +8, but then changes to giving +4 at upgrades of 9+.
The script I posted also works, more fitting to the description, by giving +2 when upgraded to 7+, and then giving another +2 (rather than a straight +4) when upgraded to 9+.
Bump.Im thinking the script should continue working past +12, but stop increasing at that point, not stop working altogether (see other scripts with these kind of effects) [beret]
Edited by MarkZD, 15 June 2012 - 06:45 PM.
@flaid you did wrong fixed for cat ears beret items at sql files.
(18600,'Cat_Ear_Beret','Cat Ear Beret',5,30,NULL,200,NULL,5,NULL,1,0xFFFFFFFF,7,2,256,NULL,0,1,761,'bonus bAspdRate,3; bonus bCritical,3; if(getrefine() >= 7) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,2; bonus bCritical,2;}',NULL,NULL);
<
i think that's script for mercury riser
I highly apologize, it's kind of late, it has got the correct script now. Fixed/optimized in r16310
