Issue Information
-
#006052
-
0 - None Assigned
-
New
Issue Confirmations
-
Yes (1)No (0)
0
[Wanderer, Maestro/Minstrel] Chorus skills still not fixed
Posted by Hercules Bot on 18 June 2012 - 01:41 AM
Originally posted by Majinken
http://rathena.org/b...-chorus-skills/
Still not fixed, I can still cast chorus skills with one character not in a party. The only skill I can't use alone is Great Echo.
http://irowiki.org/wiki/Chorus_Skill
http://rathena.org/b...-chorus-skills/
Still not fixed, I can still cast chorus skills with one character not in a party. The only skill I can't use alone is Great Echo.
http://irowiki.org/wiki/Chorus_Skill
Notes
- Chorus skills require at least two performers (Maestro or Wanderer, in any combination) in the same party, with an instrument and whip equipped and both players on the caster's screen.
Originally posted by Majinken
Up, still not fixed even on the latest revision. It's in pre-re mode, if that helps.
Up, still not fixed even on the latest revision. It's in pre-re mode, if that helps.
Originally posted by Majinken
Is this fixed?
Is this fixed?
Originally posted by Baalberith
Still not fixed, however Great Echo works OK and checks for partner.
Still not fixed, however Great Echo works OK and checks for partner.
Originally posted by Baalberith
The most straight-forward solution seems to me adding the other chorus skills to the great echo check:
The most straight-forward solution seems to me adding the other chorus skills to the great echo check:
+ case WM_SONG_OF_MANA:
+ case WM_DANCE_WITH_WUG:
+ case WM_SOUND_OF_DESTRUCTION:
+ case WM_SATURDAY_NIGHT_FEVER:
+ case WM_LERADS_DEW:
+ case WM_MELODYOFSINK:
+ case WM_BEYOND_OF_WARCRY:
+ case WM_UNLIMITED_HUMMING_VOICE:
case WM_GREAT_ECHO: {
int count;
count = skill_check_pc_partner(sd, skill, &lv, skill_get_splash(skill,lv), 0);
if( count < 1 ) {
clif_skill_fail(sd,skill,USESKILL_FAIL_NEED_HELPER,0);
return 0;
} else
require.sp -= require.sp * 20 * count / 100; // -20% each W/M in the party.
}
break;
Also please note that in function skill_check_pc_partner(), there is a line, that some compilers may not parse correctly:bool is_chorus = (skill_get_inf2(skill_id)&INF2_CHORUS_SKILL); should be changed to: bool is_chorus = ( (skill_get_inf2(skill_id)&INF2_CHORUS_SKILL) != 0); or int is_chorus = (skill_get_inf2(skill_id)&INF2_CHORUS_SKILL);
Edited by Baalberith, 28 November 2012 - 10:13 PM.
