Issue Information
-
#006066
-
3 - Medium
-
Fixed
Issue Confirmations
-
Yes (5)No (0)
0
Originally posted by MarkZD
Here's my EDP fix, based upon rA comment source, iRO source and etc.
This will also fix huge damage of normal attack and skills in RE like Rolling Cutter: http://sourceforge.n...hangeset/16322/
Also, in status.c:
wATK should be increased by 5 & bATK by 4, but it's inverted
Also, it should be eATK not bATK, but we need Renewal atk changes to do that perfectlly.
Here's my EDP fix, based upon rA comment source, iRO source and etc.
if( sc->data[SC_EDP] ){
switch(skill_num){
case AS_SPLASHER: case AS_VENOMKNIFE:
case ASC_METEORASSAULT:
break;
#ifdef RENEWAL_EDP
case AS_SONICBLOW:
case ASC_BREAKER:
case GC_COUNTERSLASH:
case GC_CROSSIMPACT:
ATK_RATE(50); // only modifier is halved but still benefit with the atk and weapon bonus
break;
#else
case ASC_BREAKER: break;
default:
ATK_ADDRATE(sc->data[SC_EDP]->val3);//It doesn't exist in RENEWAL
#endif
}
}
This "atk_addrate" is from PRE because in Renewal, base atk and weapon attack are increased instead of this final addition, and base&weapon attack are coded in status.cThis will also fix huge damage of normal attack and skills in RE like Rolling Cutter: http://sourceforge.n...hangeset/16322/
Also, in status.c:
wATK should be increased by 5 & bATK by 4, but it's inverted
Also, it should be eATK not bATK, but we need Renewal atk changes to do that perfectlly.
Originally posted by Angezerus
Yes, but batk uses stats as well doesen't it? EDP should not affect anything that comes from stats.
I'm just saying bATK because there's not an eATK implemented in source and bATK is dealing a near damage as well currently.So it's easy to understand.
Yes, but batk uses stats as well doesen't it? EDP should not affect anything that comes from stats.
Originally posted by MarkZD
Yes, it'd be good if a dev could give some word here about it.
Yes, but batk uses stats as well doesen't it? EDP should not affect anything that comes from stats.
Yes, it'd be good if a dev could give some word here about it.
Edited by MarkZD, 24 June 2012 - 08:23 PM.
Originally posted by MarkZD
The main problem is that Atk calculation from Renewal is not implemented yet:
So, if we want EDP to performs correctly, it has to be changed before.
The main problem is that Atk calculation from Renewal is not implemented yet:
http://rathena.org/b..._7359#entry7359I assume you are talking about renewal ATK here. The formula currently employed is indeed far from correct. Research on that subject is ongoing, but I expect it will be a while before we get it done.
So, if we want EDP to performs correctly, it has to be changed before.
Edited by MarkZD, 24 June 2012 - 08:54 PM.
Originally posted by InfectedX
so ._. is this skill bugged? also it affects to Boss monsters, xD i think that's a bug also...
so ._. is this skill bugged? also it affects to Boss monsters, xD i think that's a bug also...
Originally posted by Angezerus
What do you mean? EDP should add damage on boss monsters as well, only the deadly poison status is not dealt.
so ._. is this skill bugged? also it affects to Boss monsters, xD i think that's a bug also...
What do you mean? EDP should add damage on boss monsters as well, only the deadly poison status is not dealt.
Originally posted by InfectedX
yeah, that's what i said, the skill icon says:
"Damage Increase does not apply to Boss monsters"
So, i thought it's bugged
yeah, that's what i said, the skill icon says:
"Damage Increase does not apply to Boss monsters"
So, i thought it's bugged
Originally posted by Angezerus
Then it's a description error. Surely, it should add the damage regardless of boss or not, only the poison status sould not be passed.
yeah, that's what i said, the skill icon says:"Damage Increase does not apply to Boss monsters"So, i thought it's bugged
Then it's a description error. Surely, it should add the damage regardless of boss or not, only the poison status sould not be passed.
Originally posted by InfectedX
oh i see...well i have to fix that later... anyway.
Then the last what the others has said is a real bug? i mean the GX and AssaX's damage with EDP is wrong?
oh i see...well i have to fix that later... anyway.
Then the last what the others has said is a real bug? i mean the GX and AssaX's damage with EDP is wrong?
Originally posted by Angezerus
Yes, because renewal atk is not fully implemented, and thus EDP increases wrong "stats"
oh i see...well i have to fix that later... anyway.Then the last what the others has said is a real bug? i mean the GX and AssaX's damage with EDP is wrong?
Yes, because renewal atk is not fully implemented, and thus EDP increases wrong "stats"
Originally posted by InfectedX
okay then we have to wait until the rathena staff does something XD
okay then we have to wait until the rathena staff does something XD
Originally posted by GM Takumirai
- is this the correct fix??.. and where to edit those skills ...
- is this the correct fix??.. and where to edit those skills ...
Originally posted by jTynne
This is a pretty big issue for those of us running RE servers.
This is a pretty big issue for those of us running RE servers.
Originally posted by Angezerus
This is the damage increase effect of Enchant Deadly Poison. There is no such thing as %increase or %atk rate. To make it function properly, fully implemented renewal atk formula is required, as seen below.
This is the damage increase effect of Enchant Deadly Poison. There is no such thing as %increase or %atk rate. To make it function properly, fully implemented renewal atk formula is required, as seen below.
ATK = sATK * 2 + wATK + eATK + masteries
STATUS ATK = floor ( Base level / 4 + STR + DEX / 5 + LUK / 3)Weapon ATK = (Base Weapon ATK + Variance + STR + Bonus Refinement Bonus) * Size Penalty
- Normally Neutral except when using Mild Wind.
- Ignores element resistance effects such as Raydric Card or Asprika.
- Ignores % ATK item effects such as The Sign or Hydra Card.
Variance = ± 0.05 * Weapon Level * Base Weapon ATK
STR Bonus = Base Weapon ATK * STR/200Equipment ATK is the sum of ATK gained from equips other than weapons. Support buffs tend to increase this ATK, too, but not all of them fit into this category.
- Affected by weapon element when using a melee weapon.
- Affected by ammunition element when using a ranged weapon or specific skill.
- Affected by element resistance effects such as Raydric Card or Asprika.
- Increased by % ATK item effects such as The Sign or Hydra Card.
- Multiplied by 5 when affected by Enchant Deadly Poison .
- Though the STR bonus takes Element , it is still considered Neutral .
- STR Bonus is always reduced by Ghost armor.
- STR Bonus is only reduced by Neutral resistance like Raydric card, if the weapon is Neutral too.
- Variance is a random number ranging from (-5% * Weapon Level * Base Weapon ATK) to (5% * Weapon Level * Base Weapon ATK)
Mastery ATK is a special kind of ATK that has no elemental properties. While most masteries come from Passive Skills , there are some Active Skills such as Camouflage or Zen.
- Affected by weapon element when using a melee weapon.
- Affected by ammunition element when using a ranged weapon or specific skill.
- Ammunition ATK is added here when using DEX based weapon.
- Any +ATK you get from cards, including cards in weapon, is added here.
- Affected by element resistance effects like Raydric Card or Asprika.
- Increased by % ATK item effects like The Sign and Hydra Card.
- Multiplied by 4 when affected by Enchant Deadly Poison.
- Because masteries are not elemental, they are unaffected by Ghost armors or Raydric Cards.
- Since masteries are direct increases to ATK, they are affected by skill modifiers, DEF and damage increasing/decreasing effects.
Edited by Angezerus, 05 July 2012 - 08:18 AM.
Originally posted by Ainna
Just changed from rev 16304 to recent 16433 and edp behaves very odd.
rev 16433
Dex Sin normal attack edp + venom does about 50k each hit //ODD!
while edp crossimpact +venom does 16k each hit... //right but ...
rev 16304
Normal attack edp+venom ~16k autoattack // seems alright
Edp + Venom Crossimpact ~33k per hit //should be halved!?
Just changed from rev 16304 to recent 16433 and edp behaves very odd.
rev 16433
Dex Sin normal attack edp + venom does about 50k each hit //ODD!
while edp crossimpact +venom does 16k each hit... //right but ...
rev 16304
Normal attack edp+venom ~16k autoattack // seems alright
Edp + Venom Crossimpact ~33k per hit //should be halved!?
Originally posted by Angezerus
Still waiting for renewal attack
Still waiting for renewal attack
Originally posted by GM Takumirai
- just want to bump this because this is a major problem in us svn user.
- hope there is a temporary fix for this..
- just want to bump this because this is a major problem in us svn user.
- hope there is a temporary fix for this..
Originally posted by mofo
i agree, the damage modification is out of wack. hopefully this gets fixed soon. no pressure, just sayin. =)
i agree, the damage modification is out of wack. hopefully this gets fixed soon. no pressure, just sayin. =)
Originally posted by yuda236
maybe we can help with find the real formulation the real damage, is very good effort for rathena developer.
maybe we can help with find the real formulation the real damage, is very good effort for rathena developer.
Originally posted by donkeyg
got news on this?
got news on this?
Originally posted by donkeyg
bump
bump
