Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

Issue Confirmations

  • Yes (5)No (0)
Photo

EDP should no longer increase final damage

Posted by Hercules Bot on 20 June 2012 - 03:02 AM

Originally posted by MarkZD
Here's my EDP fix, based upon rA comment source, iRO source and etc.
   if( sc->data[SC_EDP] ){
		switch(skill_num){
		 case AS_SPLASHER:		 case AS_VENOMKNIFE:
		 case ASC_METEORASSAULT:
		 break;
#ifdef RENEWAL_EDP
         case AS_SONICBLOW:
		 case ASC_BREAKER:
		 case GC_COUNTERSLASH:
		 case GC_CROSSIMPACT:
		  ATK_RATE(50); // only modifier is halved but still benefit with the atk and weapon bonus
		  break;
#else
		 case ASC_BREAKER: break;
		 default:
		  ATK_ADDRATE(sc->data[SC_EDP]->val3);//It doesn't exist in RENEWAL
#endif
		}
   }
This "atk_addrate" is from PRE because in Renewal, base atk and weapon attack are increased instead of this final addition, and base&weapon attack are coded in status.c

This will also fix huge damage of normal attack and skills in RE like Rolling Cutter: http://sourceforge.n...hangeset/16322/

Also, in status.c:
wATK should be increased by 5 & bATK by 4, but it's inverted

Also, it should be eATK not bATK, but we need Renewal atk changes to do that perfectlly.

Originally posted by exneval
11/11/2009 - Maintenance
Sakray Test Server
- While using Enchant Deadly Poison, the following skills have their attack power and SP cost changed.
	Cross Impact
		Regular
		Attack Power 1200% 1250% 1300% 1350% 1400%
		SP Cost 25
		With Enchant Deadly Poison
		Attack Power 600% 625% 650% 675% 700%
		SP Cost 50
	Counter Slasher
		Regular
		Attack Power 400% 500% 600% 700% 800%
		SP Cost 5 8 11 14 17
		With Enchant Deadly Poison
		Attack Power 200% 250% 300% 350% 400%
		SP Cost 10 16 22 28 34
	Soul Destroyer
		Regular
		Attack Power 350% 400% 450% 500% 550% 600% 650% 700% 750% 800%
		SP Cost 20 20 20 20 20 30 30 30 30 30
		With Enchant Deadly Poison
		Attack Power 170% 200% 225% 250% 275% 300% 325% 350% 375% 400%
		SP Cost 20 20 20 20 20 30 30 30 30 30
	Sonic Blow
		Regular
		Attack Power 440% 480% 520% 560% 600% 640% 680% 720% 760% 800%
		SP Cost 16 18 20 22 24 26 28 30 32 34
		With Enchant Deadly Poison
		Attack power 220% 240% 260% 280% 300% 320% 340% 360% 380% 400%
		SP Cost 32 36 40 44 48 52 56 60 64 68

Source

Changes for EDP:
Enchant Deadly Poison does not quadruple the damage of skills anymore.
Instead it adds +400% damage at the end of the damage calculation.

Examples:

EDP+Sonic blow:

Before renewal : 800%*400% = 3200% damage
Renewal : 800%+400% = 1200% damage
EDP+Sonic blow+Link
Before renewal: 800%*400%*2 = 6400% damage
Renewal : Either 800%*2+400% = 2000% damage or (800%+400%)*2 = 2400% damage (please pm me correct one)

EDP+Grimtooth

Before renewal : 200%*400% = 800% damage
Renewal : 200%+400% = 600% damage

Meleeattacks remain unchanged (qudrupling the damage for 400% damage)

Source

Originally posted by MarkZD

As of Renewal, EDP no longer increases final damage by 400%

http://irowiki.org/w...t_Deadly_Poison

What's the right, will it increase or not?

Even if does, the current code is incorrect because it's still multiplying damage as it did in PRE.

Originally posted by exneval
we should just try it ingame, iRO or kRO
not based on forum or other way

Originally posted by MarkZD

Edp does affect Rolling Cutter, without halving the skill attack.Halved Skills: Sonic Blow, Cross Impact, Soul Destroyer, Counter SlashDoes Not Affected By EDP: Grimtooth, Throw Venom Knife100% affected: Any other physical attack skills that don't do fixed damage, including Envenom, Venom Splasher, Meteor Assault, Rolling Cutter, Dark Illusion, Cross Ripper Slash, Phantom Menace, Venom Pressure, Weapon Crush, and other, card/equipment obtainable skills such as Bash, Magnum Break, Bowling Bash, Occult Impact, Pierce etc...


EDP should before add 400% and after half, should half before and after add 400% or the halved skills don't get the bonus in any case?

Edited by MarkZD, 20 June 2012 - 09:37 AM.


Originally posted by MarkZD
Here are some tests(Antler Scaraba)dic_dun02:

EDP adds 300% to final skillratio. (I checked after it was 300, but I was guessing about)
normal attack(edp): up to 2k
Rolling Cutter(edp): 8~11k
cross impact(edp): 12~15k
cross impact(edp+poison weapon): 15~19k
cross impact(edp+venom impress): 17~24k

4x normal atk, no multiplier to any skills by edp
normal attack(edp): up to 7k
Rolling Cutter(edp): 4~6k
cross impact(edp): 10~12k
cross impact(edp+poison weapon): 12~17k
cross impact(edp+venom impress): 17~21k

I think the second Rolling Cutter looks like near the video damage, the one increased by 300%(not even 400%) is very higher than official damage, and I'm just using the video weapon.
About normal atk, I'm not sure yet, but it's a high damage, imagine in pvp 400% would be like 9k without venom impress and you can hit with a high aspd.

And it all with no bonus against demi-human.

Edited by MarkZD, 20 June 2012 - 10:08 AM.


Originally posted by MarkZD


Originally posted by MarkZD
Also, your source looks very old, it's from 2009 just the begining of Renewal.

Edited by MarkZD, 20 June 2012 - 10:39 AM.


Originally posted by malufett

Also, your source looks very old, it's from 2009 just the begining of Renewal.

Even though its old but still its never been changed...


and I notice that those skill that had been nerfed when edp is active is that their SP consumption increases...

anyways I'll try to confirm in game(kRO)

Originally posted by Angezerus
What about the watk*5, eatk*4 formula? Even calculators use that formula..

Btw
I had some posts regarding the formula here:
http://rathena.org/b...e-5778-edp-bug/

Edited by Angezerus, 20 June 2012 - 02:58 PM.


Originally posted by Angezerus
I just noticed something.

11/11/2009 - MaintenanceSakray Test Server- While using Enchant Deadly Poison, the following skills have their attack power and SP cost changed.	Cross Impact		Regular		Attack Power 1200% 1250% 1300% 1350% 1400%		SP Cost 25		With Enchant Deadly Poison		Attack Power 600% 625% 650% 675% 700%		SP Cost 50	Counter Slasher		Regular		Attack Power 400% 500% 600% 700% 800%		SP Cost 5 8 11 14 17		With Enchant Deadly Poison		Attack Power 200% 250% 300% 350% 400%		SP Cost 10 16 22 28 34	Soul Destroyer		Regular		Attack Power 350% 400% 450% 500% 550% 600% 650% 700% 750% 800%		SP Cost 20 20 20 20 20 30 30 30 30 30		With Enchant Deadly Poison		Attack Power 170% 200% 225% 250% 275% 300% 325% 350% 375% 400%		SP Cost 20 20 20 20 20 30 30 30 30 30	Sonic Blow		Regular		Attack Power 440% 480% 520% 560% 600% 640% 680% 720% 760% 800%		SP Cost 16 18 20 22 24 26 28 30 32 34		With Enchant Deadly Poison		Attack power 220% 240% 260% 280% 300% 320% 340% 360% 380% 400%		SP Cost 32 36 40 44 48 52 56 60 64 68
Source
Changes for EDP:Enchant Deadly Poison does not quadruple the damage of skills anymore.Instead it adds +400% damage at the end of the damage calculation.Examples:EDP+Sonic blow:Before renewal : 800%*400% = 3200% damageRenewal : 800%+400% = 1200% damageEDP+Sonic blow+LinkBefore renewal: 800%*400%*2 = 6400% damageRenewal : Either 800%*2+400% = 2000% damage or (800%+400%)*2 = 2400% damage (please pm me correct one)

EDP+GrimtoothBefore renewal : 200%*400% = 800% damage
Renewal : 200%+400% = 600% damage

Meleeattacks remain unchanged (qudrupling the damage for 400% damage)
Source



The edp post by atum is surely long outdated. Grimtooth is not affected at all.

So most likely we should stick to the known weapon atk*5 equip atk*4 formula.
If we use it on skills that are affected, and half the modifier on the ones that are needed to be halved, then we are ok.

The only question is that whether its *5 and *4 for all levels, and only duration and poison chance changes, or there is a formula for both modifier. This needs to be tested.

Edited by Angezerus, 20 June 2012 - 02:58 PM.


Originally posted by Angezerus
http://forums.irowik...=23796&page=187

Atum himself stated the watk*5 eatk*4 formula later, in the same topic after gravity made the third change on edp
(1st: +400%, 2nd 300%, 3rd watk*5 eatk*4)

No.
EDP multiplies weapon atk by 5 and equip atk by 4 (if i remember correctly) but leaves status atk alone



/Edit...

OMG it just became clear to me. It's not even base atk. It's equipment attack. Okay, so:

Weapon attack*5
Equipment attack*4 (Cards and stuff)
Base (status) attack not affected!

So, the current formula is bugged because of this. Now, we use BATK(Base Attack) instead of equipment attack!

/EDIT2
Another source, before they confirmed the *5 *4 formula:
http://forums.irowik...t=33450&page=64

Originally Posted by Clogon Posted Image
EDP was changed 3 times with the implementation of RE.

1) +400% atk buff = EDP not affected by by Racials.
2) 3x final damage = EDP affected by Racials.

3) 5x (4x need to double check this some time) [e.atk + w.atk] = EDP affected by Racials.


Edited by Angezerus, 20 June 2012 - 03:03 PM.


Originally posted by exneval
maybe this can help a lot

Originally posted by GM Takumirai
EDP + rolling cutter x10 + cross ripper slasher = high damage, can someone confirm this damage..

Originally posted by RiverStyx
Confirmed, the damage is insane, GX's soloing beelzbub with a 4x mummy main gauche? lolwut.

Originally posted by MarkZD
Considering the current formula, mine is more apropprieted.
But, apparently eATK should be increased instead of bATK in status.c.

Equipment ATK is the sum of ATK gained from equips other than weapons. Support buffs tend to increase this ATK, too, but not all of them fit into this category.


Properties

  • Affected by weapon element when using a melee weapon.
  • Affected by ammunition element when using a ranged weapon or specific skill.
  • ammunition ATK is added here when using DEX based weapon
  • Any +ATK you get from cards, including cards in weapon, is added here
  • Affected by element resistance effects like Raydric Card or Asprika.
  • Increased by % ATK item effects like The Sign and Hydra Card.
  • Multiplied by 4 when affected by Enchant Deadly Poison.


Edited by MarkZD, 23 June 2012 - 11:19 PM.


Originally posted by MarkZD
And, if NORMAL attack is still affected by EDP final increase, so this:

  if( !skill_num )
  {
   ATK_RATE(skillratio);
  }

should be changed to:
  if( !skill_num )
  {
   if( sc->data[SC_EDP] )
    skillratio += sc->data[SC_EDP]->val3 + 100;
   ATK_RATE(skillratio);
  }

Edited by MarkZD, 23 June 2012 - 11:54 PM.


Originally posted by Angezerus

And, if NORMAL attack is still affected by EDP final increase, so this:

  if( !skill_num )  {   ATK_RATE(skillratio);  }
should be changed to:
  if( !skill_num )  {   if( sc->data[SC_EDP] )	skillratio += sc->data[SC_EDP]->val3 + 100;   ATK_RATE(skillratio);  }



Normal attack is not affected. Only weapon and equipment.

Originally posted by MarkZD
There's another problem: wATK should be increased by 5 & bATK by 4, but it's inverted.

Originally posted by Angezerus

There's another problem: wATK should be increased by 5 & bATK by 4, but it's inverted.


batk eatk :D But right. Theres a post about it.

Originally posted by MarkZD
I'm just saying bATK because there's not an eATK implemented in source and bATK is dealing a near damage as well currently.

So it's easy to understand.