Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

Issue Confirmations

  • Yes (0)No (0)
Photo

Whitesmith Weapon Refine (as a Mechanic)

Posted by Hercules Bot on 13 July 2012 - 12:18 PM

Originally posted by jTynne
<p>A player was using Weapon Refine to refine their Hurricane&#39;s Fury, and it seemingly broke between 1 to 2.<br/>
<br/>
                                                                                                                       
id time char_id type nameid amount refine card0 card1 card2 card3 map
  Edit   Inline Edit   Copy Delete 18450743 2012-07-13 08:00:24 3982 X 1377 -1 0 0 0 0 0 prt_in
  Edit   Inline Edit   Copy Delete 18450744 2012-07-13 08:00:24 3982 X 1377 1 1 0 0 0 0 prt_in
  Edit   Inline Edit   Copy Delete 18450753 2012-07-13 08:00:29 3982 X 1377 -1 0 0 0 0 0 prt_in
<br />
Player was a Mechanic, had the proper materials, and was using the Weapon Refine skill.</p>

Originally posted by malufett
make sure the char has a sufficient job levels..
Working as Intended....

Originally posted by jTynne
Did you even bother reading my report? o.O

I said their item broke while it was still +1 trying to go to +2. I've never had a single item break prior to the +4 refine rating, whether Hollenghren or via Weapon Refine skill. When was this changed?

Originally posted by Ind
you see
			per = status_get_refine_chance(ditem->wlv, (int)item->refine);
			per += (((signed int)sd->status.job_level)-50)/2; //Updated per the new kro descriptions. [Skotlex]
if the job level was lower than 50 the percentage boost would be negative, therefore changing the 100% success rate of the item.

Originally posted by malufett
yes it was intended...

per = status_get_refine_chance(ditem->wlv, (int)item->refine);
per += (((signed int)sd->status.job_level)-50)/2; //Updated per the new kro descriptions. [Skotlex]

pc_delitem(sd, i, 1, 0, 0, LOG_TYPE_OTHER);
if (per > rnd() % 100) {

as you can see the code above when your job level is less than 50 the chance is decrease...

XD..sir Ind got first before me...

Originally posted by jTynne
I'M FINNA FIGHT SOMEONE
Alrighty, thank you for the clarification ;_;

moved issue from Skills