Issue Information
-
#006254
-
0 - None Assigned
-
New
Issue Confirmations
-
Yes (0)No (0)
0
Originally posted by Raizen
Hello, I was testing the emulator from Cronus-Emulator.com Project and spotted a problem in the ability AS_GRIMTOOTH, analyzing the code made ​​the correction:
in battle.c locate:
and replace to:
After, locate:
Hello, I was testing the emulator from Cronus-Emulator.com Project and spotted a problem in the ability AS_GRIMTOOTH, analyzing the code made ​​the correction:
in battle.c locate:
// FIX ME: Should Rolling Cutter be affected by EDP?
switch(skill_num){
case AS_SPLASHER: case AS_VENOMKNIFE:
case AS_GRIMTOOTH: case GC_ROLLINGCUTTER:
break;
#ifndef RENEWAL_EDP
and replace to:
// FIX ME: Should Rolling Cutter be affected by EDP?
switch(skill_num){
case AS_SPLASHER: case AS_VENOMKNIFE:
case GC_ROLLINGCUTTER:
break;
#ifndef RENEWAL_EDP
After, locate:
case GC_COUNTERSLASH: case GC_CROSSIMPACT: ATK_RATE(50); // only modifier is halved but still benefit with the damage bonus break;and replace to:
case GC_COUNTERSLASH: case GC_CROSSIMPACT: case AS_GRIMTOOTH: ATK_RATE(50); // only modifier is halved but still benefit with the damage bonus break;
Originally posted by Lighta
Not really, but actually you didn't state the issue, what you mean by not working ? seem working fine here.
Otherwise here the switch you talking about on latest revision :
switch(skill_num){
case AS_SPLASHER: case AS_VENOMKNIFE:
case AS_GRIMTOOTH: case GC_ROLLINGCUTTER:
break;
#ifndef RENEWAL_EDP
case ASC_BREAKER: case ASC_METEORASSAULT: break;
#else
case AS_SONICBLOW:
case ASC_BREAKER:
case GC_COUNTERSLASH:
case GC_CROSSIMPACT:
ATK_RATE(50); // only modifier is halved but still benefit with the damage bonus
break;
#endif
default:
ATK_ADDRATE(sc->data[SC_EDP]->val3);
}
The 1st part were AS_GRIMTOOTH set originilly is skill that doens't get the atk bonus from edp.
The second part where you put it is to halve dammge, actually I think this is a bit wrong since we can't have the bonus with this break neither, (we should have the bonus then halve imo).
Last part is default case for all other : to add edp bonus.
So in short even if it was correct you will halved GRIMTOOTH dammage and add EDP bonus. Irowiki state you shouldn't have bonus, so I think it's not right.
Not really, but actually you didn't state the issue, what you mean by not working ? seem working fine here.
Otherwise here the switch you talking about on latest revision :
switch(skill_num){
case AS_SPLASHER: case AS_VENOMKNIFE:
case AS_GRIMTOOTH: case GC_ROLLINGCUTTER:
break;
#ifndef RENEWAL_EDP
case ASC_BREAKER: case ASC_METEORASSAULT: break;
#else
case AS_SONICBLOW:
case ASC_BREAKER:
case GC_COUNTERSLASH:
case GC_CROSSIMPACT:
ATK_RATE(50); // only modifier is halved but still benefit with the damage bonus
break;
#endif
default:
ATK_ADDRATE(sc->data[SC_EDP]->val3);
}
The 1st part were AS_GRIMTOOTH set originilly is skill that doens't get the atk bonus from edp.
The second part where you put it is to halve dammge, actually I think this is a bit wrong since we can't have the bonus with this break neither, (we should have the bonus then halve imo).
Last part is default case for all other : to add edp bonus.
So in short even if it was correct you will halved GRIMTOOTH dammage and add EDP bonus. Irowiki state you shouldn't have bonus, so I think it's not right.
Originally posted by Raizen
I apologize, but before I do this modification, one of my users could not use the skill normally. I did not tested directly, just tried to fix the error and it really worked for him.
I apologize, but before I do this modification, one of my users could not use the skill normally. I did not tested directly, just tried to fix the error and it really worked for him.
Originally posted by Raizen
Ok, i'm sorry, this is an bRO question. In iRO are correct.
Ok, i'm sorry, this is an bRO question. In iRO are correct.
