EDP on Grimtooth not working properly (PRE-RE)

Originally posted by malufett
in PRE-RE EDP doesn't boost grim tooth.....

Originally posted by emong
^Thanks for the clarification.

Originally posted by Leeg
Are you sure? I found this in iROWiki:

http://irowiki.org/wiki/Grimtooth
Renewal iROwiki:
Grimtooth no longer stacks with Enchant Deadly Poison since Renewal.

Originally posted by Daegaladh
iROwiki is right, it used to stack with EDP in PRE-RE iRO. Also it still works on iRO's Classic server.

Originally posted by MarkZD
To Devs:
You can consider using my formula till we have Re-ATK implemented.

   if( sc->data[SC_EDP] ){
		switch(skill_num){
		 case AS_SPLASHER:		 case AS_VENOMKNIFE:
		 case ASC_METEORASSAULT:
		 break;
#ifdef RENEWAL_EDP
		 case AS_SONICBLOW:
		 case ASC_BREAKER:
		 case GC_COUNTERSLASH:
		 case GC_CROSSIMPACT:
		  ATK_RATE(50); // only modifier is halved but still benefit with the atk and weapon bonus
		  break;
#else
		 case ASC_BREAKER: break;
		 default:
		  ATK_ADDRATE(sc->data[SC_EDP]->val3);//It doesn't exist in RENEWAL
#endif
		}
   }

Originally posted by Mysterious
Doesn't EDP already affect grimtooth?

if( sc->data[SC_EDP] ){
   // FIX ME: Should Rolling Cutter be affected by EDP?
	switch(skill_num){
	 case AS_SPLASHER:	   case AS_VENOMKNIFE:
	 case AS_GRIMTOOTH: case GC_ROLLINGCUTTER:
	 break;
#ifndef RENEWAL_EDP
	 case ASC_BREAKER:	   case ASC_METEORASSAULT: break;
#else
	 case AS_SONICBLOW:
	 case ASC_BREAKER:
	 case GC_COUNTERSLASH:
	 case GC_CROSSIMPACT:

https://rathena.svn....rc/map/battle.c

Originally posted by kyeme
Bump~

Originally posted by MarkZD
Confirmed.
This post wasn't meant to bump, I was writing something but I saw it was incorrect.

Edited by MarkZD, 12 November 2012 - 06:40 AM.

Originally posted by Angezerus

in PRE-RE EDP doesn't boost grim tooth.....

It does. It is a RE behaviour not to stack with grim.

Originally posted by emong
BTW something to add guys..

http://rathena.org/b...dp/#entry158730

Meteor assault, sonic blow and soul breaker doesn't increase damage after using edp. . bumping up.

Bump~

We implemented EDP properly for both pre-renewal and renewal on rAthena already 1-2 years ago based on the info we collected about it.

It looks like this:
https://github.com/r...rc/map/battle.c

case AS_SPLASHER:
// Pre-Renewal only: Soul Breaker and Meteor Assault ignores EDP
// Renewal only: Grimtooth and Venom Knife ignore EDP
// Both: Venom Splasher ignores EDP [helvetica]
#ifndef RENEWAL
case ASC_BREAKER:
case ASC_METEORASSAULT:
#else
case AS_GRIMTOOTH:
case AS_VENOMKNIFE:
#endif
break; // skills above have no effect with edp

In Hercules it's still very bugged. The code is a bit different because you split renewal EDP and pre-renewal EDP up completely, so in Herc it's this for renewal:

#ifdef RENEWAL_EDP
if( sc->data[SC_EDP] && skill_id != AS_GRIMTOOTH && skill_id != AS_VENOMKNIFE && skill_id != ASC_BREAKER ){
eatk = eatk * (sc->data[SC_EDP]->val4 / 100 - 1);
damage = damage * (sc->data[SC_EDP]->val4 / 100);
}
#endif

And this for pre-renewal:

#ifndef RENEWAL_EDP
if( sc->data[SC_EDP] ){
switch(skill_id){
case AS_SPLASHER:
case AS_GRIMTOOTH:
case ASC_BREAKER:
case AS_VENOMKNIFE:
case ASC_METEORASSAULT: break;
default:
ATK_ADDRATE(sc->data[SC_EDP]->val3);
}
}
#endif

This should be fairly easy to fix... just remove AS_GRIMTOOTH and AS_VENOMKNIFE from the pre-renewal code and replace ASC_BREAKER with AS_SPLASHER in renewal code.

Of course this is assuming that the rAthena implementation is correct. I'm pretty sure about Grimtooth working in pre-renewal but not anymore in renewal and I'm also pretty sure that Soul Breaker is affected in renewal, but I'm not sure about AS_SPLASHER and AS_VENOMKNIFE.

bump

I've submitted a fix for Grimtooth. However, I need more info for Venom Knife and Venom Splasher, does EDP increases damage for these two skills in Pre-Re?

venom knife i don't have info on it, venom splasher works like pre-re SD/SBK only affected by raw atk and not affected by edp. i was reading my old ep.4 guide book for pRO lol !