Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

Issue Confirmations

  • Yes (0)No (0)
Photo

Magic Book Quest Typo

Posted by Hercules Bot on 20 July 2012 - 12:25 AM

Originally posted by Aleos
There are two locations in the quest that doesn't allow players to get past the base level, Tetra Vortex, and Comet check.
if ((BaseLevel < 140) || (getskilllv(2217) < 1) && (getskilllv(2213) < 1)) {
Lines 1686 and 1896

iRO Wiki says that Tetra Vortex and/or Comet are/is required. So changing the && to || will resolve this issue.

Originally posted by Euphy
The scripting isn't standard, but it's not incorrect.  I could get past the checks having either skill.

Originally posted by malufett

The scripting isn't standard, but it's not incorrect.  I could get past the checks having either skill.

hmm...

if( true || false && true)

will result to true where it says I passed the minimum level and I have either the skills

but what if

if( true || false && false)

will also result to true where it says I passed the minimum level and I don't have either the two skills

and what about if

if( false || true && true)

resulting to true where I fail the minimum level and I have the two skills..

anyway this is just my observation but I don't know what the quest really does...:)

Originally posted by Euphy
I honestly have no idea how the conditionals work when mixing &&/||, but from what I tested:
  • True ~ False ~ False = Check failed
  • False ~ True ~ False = Check failed
  • False ~ False ~ True = Check failed
  • False ~ False ~ False = Check failed
All other cases pass the check, so it works.