Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #006288

  • 0 - None Assigned

  • Fixed

Issue Confirmations

  • Yes (4)No (0)
Photo

experience in "pre-re" scripts

Posted by Hercules Bot on 20 July 2012 - 10:02 AM

Originally posted by wend
exp, obtained through the "getexp" 10 times more than necessary

Originally posted by malufett
hmm..did you check your rates? what is your rate?

Originally posted by Daegaladh
I think he means that pre-renewal scripts have renewal exp rewards (that generally are 10 times less than pre-re)

e.g.: Onward to the New World Quest
Renewal:
Base Experience: 132,000
Job Experience: 42,000

Pre-renewal:
Base Experience: 1,320,000
Job Experience: 420,000

I'm working on it at the moment, but it will take me some time, because I'm also fixing pre-re monster spawns and warps

Originally posted by wend
sorry, my mistake, 10 times less, not more

for example:

quests_13_2.txt, line 5702

getexp 0,70000;
should be
getexp 0,700000;

quests_morocc.txt, line 1621
getexp 200000,0;
should be
getexp 2000000,0;


Originally posted by Masao
As far as I know, and I think I've said this also already a billion times now, the exp in quest files is handled via the source code since ALL exp calculations are done there, and in the config folder were you decide if you want re enabled or not, it will take the exp from the quest file and make it exp / 10 if renewal is enabled and otherwise if renewal is not enabled it will take the exp as they're defined in the quest file.

So I really don't think there are any modifications needed.

Originally posted by wend
but on "pre-re" and on "re" server if I write "getexp 10, 0" - I get 10 exp, not 1 or 100.

Originally posted by Daegaladh
@Masao, but this should be by default when you set your server as pre-re...
Also, not all quests in pre-re gives x10 exp, there are some that gives totally different values.

Originally posted by Toshiro
Since the checkre() command was added, this could easily be fixed to support both, pre-re and re values.

Originally posted by Muad_Dib
Actualy it can't tho initialy RE exp was /10 they adjusted a lot if quests now by hand for the RE exp. to be different from /10

Originally posted by Daegaladh
Don't worry I'm fixing this atm. I'll commit the fix soon ;)

Originally posted by DeePee
Cursed Spirit Quest has the wrong EXP values as well, even before rA existed.

   	 if (v[VAR_CLEVEL] < 70)
            getexp 800000
            getJexp 300000
        elseif ((v[VAR_CLEVEL] > 69) & (v[VAR_CLEVEL] < 80))
            getexp 1000000
            getJexp 500000
        elseif ((v[VAR_CLEVEL] > 79) & (v[VAR_CLEVEL] < 90))
            getexp 1500000
            getJexp 800000
        elseif ((v[VAR_CLEVEL] > 89) & (v[VAR_CLEVEL] < 100))
            getexp 2000000
            getJexp 1000000
        endif

http://irowiki.org/c...ed_Spirit_Quest

Pre-RE rAthena/eAthena:

   	 if (BaseLevel < 70)
            getexp 80000,30000;
        else if ((BaseLevel > 69) && (BaseLevel < 80))
            getexp 100000,50000;
        else if ((BaseLevel > 79) && (BaseLevel < 90))
            getexp 150000,80000;
        else if ((BaseLevel > 89) && (BaseLevel < 151))
            getexp 200000,100000;


Originally posted by Euphy
Fixed Cursed Spirit quest in [rev=16990].

changed status to: Fixed