Issue Information
-
#006353
-
0 - None Assigned
-
Fixed
Issue Confirmations
-
Yes (9)No (1)
Using lastest SVN 16520, i'm always getting map crash when character using any skill.
already restart all server (login, char and map) and restart computer still got same problem.
Testing with character RK using equipment all RWC Hat, godly item, ahura mazdah and hunting spear.
testing with skill dragon breath, storm gust, and lorm vermilion
i'm on 2012-04-10 as well and can't reproduce uhm. my my this is scary.
the server is now become unstable on the latest revision due to server crashed problem.
i confirmed the weapon repair problem.1st i got this following item.6 Iron Ore,6 Iron,6 Steal;6 Rough Oridecon.then i destroy the item of the player using melt down.when i try to repair.You have failed to repair this item. Please check the distance between you and the opponent.then i try to go near with him around 1cell.then the skill works. i choose the weapon that i want to repair. but the server crashed. the required item still there.
try to revert the changes on this revision http://trac.rathena....t/16500/rathena then you problem will be fix. this also happen for me before. when character use weapon repair even you are on the battle. but after i tried to revert the changes it works again normally. at this time there are still no map crashed happen.
the server is now become unstable on the latest revision due to server crashed problem.
try to revert the changes on this revision http://trac.rathena....t/16500/rathena then you problem will be fix. this also happen for me before. when character use weapon repair even you are on the battle. but after i tried to revert the changes it works again normally. at this time there are still no map crashed happen.i confirmed the weapon repair problem.1st i got this following item.6 Iron Ore,6 Iron,6 Steal;6 Rough Oridecon.then i destroy the item of the player using melt down.when i try to repair.You have failed to repair this item. Please check the distance between you and the opponent.then i try to go near with him around 1cell.then the skill works. i choose the weapon that i want to repair. but the server crashed. the required item still there.
That is not the way I think, the objective is have a stable emulator for all. We must find what is causing the crash to fix it, not leave it apart.
since no developers were able to reproduce so far i need a gdb report at the very least, otherwise there is no way to tell whats causing that.
hey ind what about that line:
if (
if ( sd->inventory_data[idx]->type == IT_WEAPON)
it wasn't supposed to be changed in any patch file, maybe that is the cause?
That is not the way I think, the objective is have a stable emulator for all. We must find what is causing the crash to fix it, not leave it apart.the server is now become unstable on the latest revision due to server crashed problem.
try to revert the changes on this revision http://trac.rathena....t/16500/rathena then you problem will be fix. this also happen for me before. when character use weapon repair even you are on the battle. but after i tried to revert the changes it works again normally. at this time there are still no map crashed happen.i confirmed the weapon repair problem.1st i got this following item.6 Iron Ore,6 Iron,6 Steal;6 Rough Oridecon.then i destroy the item of the player using melt down.when i try to repair.You have failed to repair this item. Please check the distance between you and the opponent.then i try to go near with him around 1cell.then the skill works. i choose the weapon that i want to repair. but the server crashed. the required item still there.
yah you're right. we should find what is the cause of server crashed. i hope someone will figure it out of what causing server crashed.
Was this bug fixed ? Because i use my lastest svn but the map server still crashing when someone used this Repair Weapon skill.
Anyone?
have anyone tried changing:
if ( sd->inventory_data[idx]->type == IT_WEAPON)
into
if (itemdb_type(item->nameid)==IT_WEAPON)
and recompiling?
since in eAthena code it is still:
but Ind changed it, so it might be the problem?
Edited by EvilPuncker, 10 August 2012 - 08:56 PM.
ah. silly me. so it crashes when there isn't said idx in the target inventory thank you very much.have anyone tried changing:if ( sd->inventory_data[idx]->type == IT_WEAPON)intoif (itemdb_type(item->nameid)==IT_WEAPON)and recompiling?since in eAthena code it is still:but Ind changed it, so it might be the problem?
Fixed in [rev=16623] thanks to EvilPuncker
finally its working now without server crashed. thanks.