Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #006506

  • 4 - High

  • Confirmed

Issue Confirmations

  • Yes (5)No (2)
Photo

EDP + Cross Impact

Posted by Hercules Bot on 19 August 2012 - 05:32 PM

Originally posted by mofo
Updated to r16667, now EDP boosts damage of cross impact, sonic blow, soul breaker, etc. Was this change intentional? TIA

Originally posted by donkeyg
Please do some action on this EDP and CROSS IMPACT.

Originally posted by donkeyg
hey... why no respond from rathena development.. i suffer about this problem so long

Originally posted by GM Takumirai
@donkey suggest to patch the manage skill damage v.2 by Lilith
- im hoping that patch will be put in our svn so that we can easily manage the skills if we see an imbalance to the server since some skills are not yet fix totally , while waiting we can manage the skill damage by using the patch by Lilith ..

Originally posted by donkeyg

@donkey suggest to patch the manage skill damage v.2 by Lilith- im hoping that patch will be put in our svn so that we can easily manage the skills if we see an imbalance to the server since some skills are not yet fix totally , while waiting we can manage the skill damage by using the patch by Lilith ..

where can i find the patch by lilith's 1? ^^

Originally posted by donkeyg

http://rathena.org/b...kill-damage-20/


not really know how to use it.. just copy and paste? haha! btw, why kro is so slow to fix this skill?

Originally posted by Euphy
Please keep unrelated discussion out of the bug tracker.  That's what the support forums are for. ._.

Originally posted by GM Takumirai
as Euphy said we must not discuss unrelated issue in here, anyway answer to your question is that its not kRO that it make it unfixable, we have developers now starting the fix of this issue.. so wait for them and support them for there time to fix it..

Originally posted by Angezerus
Since this is more of a renewal attack issue, there is no need to modify the skills. Their formula is okay. The only problem is the missing eAtk/ wAtk separation and the missing renewal pierceing calculation.

Originally posted by donkeyg

as Euphy said we must not discuss unrelated issue in here, anyway answer to your question is that its not kRO that it make it unfixable, we have developers now starting the fix of this issue.. so wait for them and support them for there time to fix it..

Glad to heard that! hope the rathena Team will fix it as fast as possible ^^

Originally posted by arun89
still waiting for a solution to this... patiently waiting ^^

Originally posted by donkeyg
Bumppppp this thread and still havent been fix since august 20?

Originally posted by Angezerus

Bumppppp this thread and still havent been fix since august 20?


Some are not fixed since May. Be patient pz. As many ppl mentioned: these issues are related to Renewal Atk. There's no point in teporally nerfing the skill, because attack is the one that needs to be fixed. Only then can the skill formula be altered. Till then use pre renewal edp settings if neccessary.

Edited by Angezerus, 30 November 2012 - 10:24 AM.


Originally posted by powerboots
or you could use the same formula as maximum_overthrust which only boost 200% on physical attacks (make it 400% on edp)

Originally posted by Angezerus

or you could use the same formula as maximum_overthrust which only boost 200% on physical attacks (make it 400% on edp)


The problem is that EDP increases eAtk by 4 and wAtk by 5 times, but eAtk is not implemented, so once again, this needs Renewal Attack. Using other skill's formulas would make it even worse and only delay the main problem :)

Originally posted by donkeyg
O.o .. but im still prefer waiting for the rathena team's solution xD

Edited by donkeyg, 03 December 2012 - 12:54 PM.


Originally posted by powerboots
here's a fix i made my own

battle.c line 3000

if (sc->data[SC_EDP]) {
switch (skill_num) {
case AS_SPLASHER:
case AS_VENOMKNIFE:
case AS_GRIMTOOTH:
break;

grimtooth shouldn't be there. as we know grimtooth doesnt increase damage on edp skill

battle.c line 3015

ATK_RATE(50); // only modifier is halved but still benefit with the damage bonus

this part is totally wrong, atk_rate(50) means it\ll boost attack by 50%. the real damage suppose to be half which means

ATK_RATE(-50); // only modifier is halved but still benefit with the damage bonus


as for some people who wants final damage added +400%, insert this script at line 2041

if (sc->data[SC_EDP])
skillratio += sc->data[SC_EDP]->val2;


some of it might be wrong, so if anyone can check & confirm this?

anyway.. GC_CROSSRIPPERSLASHER should be added somewhere, which reduce it's attack (either does not boost or half modifier)

Edited by powerboots, 04 December 2012 - 02:07 AM.


Originally posted by Golem1988

here's a fix i made my ownbattle.c line 3000

if (sc->data[SC_EDP]) { switch (skill_num) { case AS_SPLASHER: case AS_VENOMKNIFE: case AS_GRIMTOOTH: break;



nice try man, but this code disables grimtooth on edp ;)

Originally posted by powerboots

here's a fix i made my ownbattle.c line 3000

if (sc->data[SC_EDP]) { switch (skill_num) { case AS_SPLASHER: case AS_VENOMKNIFE: case AS_GRIMTOOTH: break;

nice try man, but this code disables grimtooth on edp ;)


well.. thanks for telling it out (sorry i'm still quite new to this stuffs so there are lots of  parts where i don't understand at all.)
the only solution did i placed is that i added grimtooth to the half damage modifier because grimtooth had no delay and is crazy high damage
as for other attacks modifier, i've learn it out of coincidence (when i nerf thanatos, and boost maxoverthrust)

Edited by powerboots, 05 December 2012 - 09:25 PM.


Originally posted by Golem1988

ok let me do it..I'll do a remedy even though renewal atk is not yet fully implemented..

<c> Malufett
Okay... this is the quote from 10th of september. How many time has passed? Lemme tell you: 4 months = No result. This question was posted even earlyer.
As I see the point were to tell people "we are working on it, relax" and let all the things as they were?
I don't really believe that atk formulas are so hard to write if you really do it.
Bump, wanna hear about some changes or wanna hear what problems developers met doing this thing real. I mean doing normal atk formula real.
Bump, bump, bump. This formula ruines all tre emulator btw, people are leaving servers becaue of horrible formula, so I request some changelog from developement side. Thanks.
I still believe rA isn't dead...

Edited by Golem1988, 08 December 2012 - 05:37 PM.