Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #006527

  • 0 - None Assigned

  • Fixed

Issue Confirmations

  • Yes (1)No (1)
Photo

Talking to NPC

Posted by Hercules Bot on 21 August 2012 - 07:43 PM

Originally posted by kyeme
In Official when TALKING TO NPC you can USE USABLE ITEMS, SKILLS (Self Skills only) and CHANGE EQUIPMENTS / EQUIP/UNEQUIP (you can Change Equip except Refiner NPC). However what we have is once we talk to the NPC it will not allow us to USE usable items, skills and change equipment.
~kyeme :)

Originally posted by malufett
and I think we need to create another script command for this

(you can Change Equip except Refiner NPC)


:meow:

Originally posted by Ind

and I think we need to create another script command for this

(you can Change Equip except Refiner NPC)

:meow:

thats a rather dangerous thing to do -- it'd open exploits in many poorly scripted npcs.

Originally posted by malufett
so what shall we do? to hinder characters to change equipment/use skills/ and etc in a specific npc?? by not affecting general npc..:)

:meow:

Originally posted by Kenpachi
in AEGIS there is a script command to block the players ability to change equip... I'd say let's do it the official way.

Originally posted by malufett

in AEGIS there is a script command to block the players ability to change equip... I'd say let's do it the official way.

+1

Originally posted by Lunar
I think we have to list all npc which could be vulnerable to this behavior, like card remover, or armor enchanter (player have to take only one copy of armor)

Edited by Lunar, 23 August 2012 - 06:00 PM.


Originally posted by Leeg
I'd like to point out that in iRO you can't use self-skills or items, but you can change your equipment.

If you try to, a message is shown in the general message tab:

'any work in progress (NPC dialog, manufacturing...) quit and try again',

Originally posted by malufett

I'd like to point out that in iRO you can't use self-skills or items, but you can change your equipment.

as I checked kRO only non-self skill target cannot be used..but let me check if there is a error message when doing restricted moves...

:meow:

Originally posted by mkbu95
*enable_items;
*disable_items;

These commands enable item usage while an NPC is running. When enable_items is
run, items can be used during scripts until disable_items is called. 
To avoid possible exploits, when enable_items is invoked, it will only enable
item usage while running that script in particular. Note that if a different
script also calls enable_items, it will override the last call (so you may
want to call this command at the start of your script without assuming the
effect is still in effect).
?

Originally posted by Angezerus

and I think we need to create another script command for this

(you can Change Equip except Refiner NPC)

:meow:

thats a rather dangerous thing to do -- it'd open exploits in many poorly scripted npcs.

As long as the criteria check is in the same "frame" as the "action", there shouldn't be any problem, and afaik every official npc checks in the exact moment when it does something with an item. Or am I wrong?

Originally posted by Brian
I think leave item/skill usage disabled and let users enable item use if they want, using 'enable_items' and 'disable_items'.

Any news in kRO?

Originally posted by Leeg
I'd like to point out that in iRO you can't use self-skills or items, but you can change your equipment.

If you try to, a message is shown in the general message tab:

'any work in progress (NPC dialog, manufacturing...) quit and try again',


This behavior are now on pRO. Bifrost episode.


I confirm in iRO Sakray.

Any news in kRO?

same ways...

:meow:

If you are allowed to unequipping/equipping while talking to NPC, maybe what we should do is when there is written in the script/npc like"successrefitem, failedrefitem, successremovecards", then.. equipping and unequipping should be automatically disabled when talking to that NPC.
I would suggest this if this is possible.  :)

If you are allowed to unequipping/equipping while talking to NPC, maybe what we should do is when there is written in the script/npc like"successrefitem, failedrefitem, successremovecards", then.. equipping and unequipping should be automatically disabled when talking to that NPC.
I would suggest this if this is possible. :)

There are commands in the official scripts that toggle this functionality -- that hasn't been the problem.  Something like this will totally break custom scripts on a lot of servers, potentially creating exploits everywhere.  But I suppose it has to be done sometime. ._.

If somebody codes the source for this, I can add the commands to our scripts.

moving this to scripts

please identify all npc that needs disabling of equipping/unquipping of equipment and use this command.
*enable_items;
*disable_items;
afterwards return it here so that we can enable by default  'enable_items'

Thank you..
:meow:

moved issue from Core

I'll make a full script patch if you post a full core patch. XD
cashitem\advholgren.sc              27
local\dewata\dewata_weapon.sc      360
local\dewata\dewata_weapon.sc      423
local\malangdo\mal_jerun.sc         48
local\malangdo\mal_jerun.sc        574
local\malangdo\mal_yong.sc          25
local\malangdo\mal_yong.sc        1912
quest\2004_hat.sc                  829
quest\2005_hat.sc                 1528
quest\2005_hat.sc                 2288
quest\god\god_mjol.sc             1955
quest\god\god_mjol.sc             2310
quest\tutorial\para_suvquest.sc   3382
siglude\alberta_refine.sc          231
siglude\einbroch_refine.sc         232
siglude\lighthalzen_refine.sc      231
siglude\morocc_refine.sc           231
siglude\new_smelting.sc             27
siglude\new_smelting.sc            442
siglude\new_smelting.sc            857
siglude\payon_refine.sc            231
siglude\prontera_refine.sc         231
siglude\yuno_refine.sc             231


Attached File  r17160.patch   16.01K   7 downloads

moved issue from Scripts

changed status to: Fixed