Issue Information
-
#006548
-
0 - None Assigned
-
Done
Issue Confirmations
-
Yes (5)No (0)
0
Originally posted by exneval
In fresh revision, accidentally i figure this out,
the bCastrate bonus seems not working as intended,
How to reproduce :
1. Play a charcater [Warlock/High Wizard]
2. Use skill Mystic Amplification, ex : the cast time is 3 secs
3. Now equip Staff of Destruction
4. Use skill Mystic Amplification again
5. We will realize that the cast time more than 3 secs. Staff of Destruction should reduce cast time 50%, so it has to be 1.5 secs
6. If i change the script from
So it's a database or core related issue ?
Please confirmed if you can reproduce this issue.
Thanks.
In fresh revision, accidentally i figure this out,
the bCastrate bonus seems not working as intended,
How to reproduce :
1. Play a charcater [Warlock/High Wizard]
2. Use skill Mystic Amplification, ex : the cast time is 3 secs
3. Now equip Staff of Destruction
4. Use skill Mystic Amplification again
5. We will realize that the cast time more than 3 secs. Staff of Destruction should reduce cast time 50%, so it has to be 1.5 secs
6. If i change the script from
bonus2 bCastrate,366,-50;to
bonus2 bCastrate,366,50;Staff of destruct will reduce 50% casting time
So it's a database or core related issue ?
Please confirmed if you can reproduce this issue.
Thanks.
Originally posted by malufett
btw what are you using? Renewal mode??
btw what are you using? Renewal mode??
Originally posted by mkbu95
I tested using Renewal and indeed you have to remove the - in order to reduce the casting time.
Now, looking at pc_bonus2 in pc.c:
Doing:
But setting
From the documentation:
I tested using Renewal and indeed you have to remove the - in order to reduce the casting time.
Now, looking at pc_bonus2 in pc.c:
case SP_CASTRATE:
if(sd->skillcast[i].id == type2)
sd->skillcast[i].val += val;
else {
sd->skillcast[i].id = type2;
sd->skillcast[i].val = val;
} Changing to: sd->skillcast[i].val -= val;in both branches, works.
Doing:
bonus2 bVariableCastrate,366,-100;will reduce the variable(?) casting time by 100%.
But setting
bonus2 bCastrate,366,-100;will increase it.
From the documentation:
bonus2 bCastrate,n,x; Adjust casting time of skill n by x% (supports skill names) bonus2 bVariableCastrate,s,x; Increases variable cast time of skill s by x%. (supports skill names.)They should do the same when you insert a negative value, but they're doing the opposite.
Originally posted by malufett
no I did do nothing with SP_CASTRATE setting of value..
anyway the reason why its not working in renewal mode cause temporarily I remove its functionality by macro since I think there is no item that using it anymore(until the db devs update all re item)..but If I were wrong I'll restore it...
but I'll move this first to Databases to change all 'bCastrate' to 'bVariableCastrate'..
but please for those who will update return this if there is still item that uses 'bCastrate' in Renewal....
no I did do nothing with SP_CASTRATE setting of value..
anyway the reason why its not working in renewal mode cause temporarily I remove its functionality by macro since I think there is no item that using it anymore(until the db devs update all re item)..but If I were wrong I'll restore it...
but I'll move this first to Databases to change all 'bCastrate' to 'bVariableCastrate'..
but please for those who will update return this if there is still item that uses 'bCastrate' in Renewal....
Originally posted by mkbu95
Hmmm I see. You have a point on disabling bCastrate on re
Hmmm I see. You have a point on disabling bCastrate on re
Originally posted by exneval
ya it's working with bvariablecastrate
ya it's working with bvariablecastrate
Originally posted by Kenpachi
Okay, I'll update the RE databases later.
Okay, I'll update the RE databases later.
Originally posted by Natsu Dragneel
its working! removing - in bcastrate will remove casting. this is what I'm looking for to have instant cast with +9 gfist
its working! removing - in bcastrate will remove casting. this is what I'm looking for to have instant cast with +9 gfist
Edited by Natsu Dragneel, 01 September 2012 - 03:19 AM.
Originally posted by malufett
Bump!
Bump!
Originally posted by Spre
I changed all the bonus2 a while ago to variable. removing - does work, but the castrate function clearly states.
bonus bCastrate,n; Skill casting time rate + n%
No - should ADD cast time Not decrease it, this is the issue it is reversed, - adds no - decreases currently.
I changed all the bonus2 a while ago to variable. removing - does work, but the castrate function clearly states.
bonus bCastrate,n; Skill casting time rate + n%
No - should ADD cast time Not decrease it, this is the issue it is reversed, - adds no - decreases currently.
Originally posted by malufett
Spre can you
Thank you..
Spre can you
Okay, I'll update the RE databases later.
Thank you..
Originally posted by Spre
yea, I have to go to work early (in a half hour Ill try to get the bonus bcastrate ones done now, if not ill get them done after work.
yea, I have to go to work early (in a half hour Ill try to get the bonus bcastrate ones done now, if not ill get them done after work.
Originally posted by Spre
I have fixed it, will be comitted when sourceforge is no longer borked, tried comitting and found out they had an outage which means our svn is down, nobody can update download or comitt with the current url
I have fixed it, will be comitted when sourceforge is no longer borked, tried comitting and found out they had an outage which means our svn is down, nobody can update download or comitt with the current url
Originally posted by Spre
yea I was at work on lunch when i connected to my pc and comitted could not post it was fixed.
Fixed meaning castrate changed to variablecastrate untill castrate is determined to work properly.
Thanks kyeme
yea I was at work on lunch when i connected to my pc and comitted could not post it was fixed.
Fixed meaning castrate changed to variablecastrate untill castrate is determined to work properly.
Thanks kyeme
