Javascript Disabled Detected

You currently have javascript disabled. Several functions may not work. Please re-enable javascript to access full functionality.

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

Issue ID
#006584
Severity
3 - Medium
Status
Fixed
Return to Issue Listing

Issue Confirmations

Yes (1)No (0)

0

Deluge + Wall of Fog = Map-server Crash

Posted by Hercules Bot on 29 August 2012 - 03:08 PM

Originally posted by RaGERO
I have no custom src mods

Cast Deluge first and then overlap it with Wall of Fog, it crashes on my server using latest svn r16716

-- *EDIT* --
Also would like to add that some skills of Professor are bugged, Land Protection for example doesn't remove when you cast another Land Protection, same goes with some other ground target skills of Professor like that of Deluge + Wall of Fog.

Back to top

Hercules Bot

Aug 29 2012 04:41 PM

Originally posted by malufett
cause of crash:

if (skillid == PF_FOGWALL && alive == 2)
{ //Double duration of cells on top of Deluge/Suiton
     unit->limit *= 2;
     group->limit = unit->limit;
}

Back to top

Hercules Bot

Aug 29 2012 04:43 PM

Originally posted by RaGERO
So what's the fix sir?

Back to top

Hercules Bot

Aug 29 2012 09:30 PM

Originally posted by wend
confirm

problem here, i think: (skil.c)

map_foreachincell(skill_cell_overlap,src->m,ux,uy,BL_SKILL,skillid, src);

should be:

map_foreachincell(skill_cell_overlap,src->m,ux,uy,BL_SKILL,skillid,&alive,src);

Edited by wend, 29 August 2012 - 09:31 PM.

Back to top

Hercules Bot

Aug 29 2012 11:18 PM

Originally posted by RaGERO

confirmproblem here, i think: (skil.c)

map_foreachincell(skill_cell_overlap,src->m,ux,uy,BL_SKILL,skillid, src);

should be:

map_foreachincell(skill_cell_overlap,src->m,ux,uy,BL_SKILL,skillid,&alive,src);

Confirmed fixed!
Thanks wend! Also looked at the older revisions and there's '&alive' value in the function.
This also fixed the LP + Safety Wall issue and LP overlapping with other Prof's LP.

Edited by RaGERO, 29 August 2012 - 11:45 PM.