Issue Information
-
#006692
-
0 - None Assigned
-
Fixed
Issue Confirmations
-
Yes (0)No (0)
0
[rev=16776] Added the IFDEF RENEWAL, then updated in [rev=16778] (renamed re-pre to pre-re)
As it stands, i get errors on my dev server. Shouldn't that line be:
sv_readdb(db_path, "pre-re/skill_cast_db.txt" , ',', 7, 8, MAX_SKILL_DB, skill_parse_row_castdb);
At the moment, it's not reading some lines due to there being 8 parameters.
Or they both could use DBPATH as I believe that why it was for.
(Only change would be the min and max column to parse then, won,t change much cus if I recall they'll be default to 0 if nothing there..)
The min and max were indeed changed, which broke something. The min/max were changed from 7-8 to 7-7, and as some of the skills have 8 columns, they were no longer read.
This is from [rev=16776]:
- sv_readdb(db_path, DBPATH"skill_cast_db.txt" , ',', 7, 8, MAX_SKILL_DB, skill_parse_row_castdb); +#ifdef RENEWAL + sv_readdb(db_path, "re/skill_cast_db.txt" , ',', 8, 8, MAX_SKILL_DB, skill_parse_row_castdb); +#else + sv_readdb(db_path, "re-pre/skill_cast_db.txt" , ',', 7, 7, MAX_SKILL_DB, skill_parse_row_castdb); +#endif
(Only change would be the min and max column to parse then, won,t change much cus if I recall they'll be default to 0 if nothing there..)
The min and max were indeed changed, which broke something. The min/max were changed from 7-8 to 7-7, and as some of the skills have 8 columns, they were no longer read.
working as intended..since fixed cast time in re is not anymore optional...and I don't think there is a 8 columns in pre..
There's a few:
//-- GN_HELLS_PLANT 2490,3000:3500:4000:4500:5000,500,0,14000:21000:28000:35000:42000,0,0,0
but the question is..is it needed in pre?
If it's not needed, it shouldn't still be in the pre-re/skill_cast_db.txt file
maybe its a typo..hahaha
Up!
https://rathena.svn....ill_cast_db.txt
693,0,0,0,0,0,300000,0
1-2-3-4-5-6-7-8
And have error
[Error]: sv_readdb: Too many columns in line 1027 of "db/pre-re/skill_cast_db.txt" (found 8, maximum is 7).
Like this ? post:13914Up!https://rathena.svn....ill_cast_db.txt693,0,0,0,0,0,300000,01-2-3-4-5-6-7-8And have error[Error]: sv_readdb: Too many columns in line 1027 of "db/pre-re/skill_cast_db.txt" (found 8, maximum is 7).
this =((Only change would be the min and max column to parse then, won,t change much cus if I recall they'll be default to 0 if nothing there..)The min and max were indeed changed, which broke something. The min/max were changed from 7-8 to 7-7, and as some of the skills have 8 columns, they were no longer read.
Fixed in [rev=16789].
