Issue Information
-
#006714
-
0 - None Assigned
-
Fixed
Issue Confirmations
-
Yes (3)No (1)
Originally posted by kyeme
Why some item script have /* */
like example
Reporting and asking
Why some item script have /* */
like example
2568,Muffler_Of_Roki,Loki's Muffler,5,20,,400,,10,,0,0xFFFFFFFF,7,2,4,,100,0,0,{ bonus bAgi,1; /* bonus2 bSkillAtk,"GC_CROSSIMPACT",5; */ },{},{}
Reporting and asking
Originally posted by nanakiwurtz
Wew...
It's just an ordinary Comment Block.
A commented code won't be processed, there're 2 way to comment.
First, comment a line
Wew...
It's just an ordinary Comment Block.
A commented code won't be processed, there're 2 way to comment.
First, comment a line
1 2 //3 <-- commentedSecond, comment a block
/* 1 2 3 */In item script, actually it's just a compacted lines, so it's become a single line.
Originally posted by EvilPuncker
I think that he is asking why they are commented, the answer is that when they were implemented those skills/bonuses were not coded yet, now they are, that is why kenpachi confirmed this
Wew...It's just an ordinary Comment Block.A commented code won't be processed, there're 2 way to comment.First, comment a line
12//3 <-- commentedSecond, comment a block/*123*/In item script, actually it's just a compacted lines, so it's become a single line.
I think that he is asking why they are commented, the answer is that when they were implemented those skills/bonuses were not coded yet, now they are, that is why kenpachi confirmed this
Edited by EvilPuncker, 20 September 2012 - 02:01 AM.
Originally posted by kyeme
Oh iseee ThanksI think that he is asking why they are commented, the answer is that when they were implemented those skills/bonuses were not coded yet, now they are, that is why kenpachi confirmed thisWew...It's just an ordinary Comment Block.A commented code won't be processed, there're 2 way to comment.First, comment a line
12//3 <-- commentedSecond, comment a block/*123*/In item script, actually it's just a compacted lines, so it's become a single line.
Originally posted by Spre
I spent alot of time today trying to test those, if noone gets to it i'll finish testing them by weeks end and see.
I started working again today/yesterday 4:30 to 1am so yea
I spent alot of time today trying to test those, if noone gets to it i'll finish testing them by weeks end and see.
I started working again today/yesterday 4:30 to 1am so yea
Originally posted by Kabal
This causes errors in my mapserv. Remembering that I use in the SQL item_db_re.
This causes errors in my mapserv. Remembering that I use in the SQL item_db_re.
Originally posted by Spre
Well first, you cannot just uncomment them all, some functions still do not exist.
For example madoheal is not a working function.
Second I have finished them, I just need a final approval before they can be comitted, awaiting on euphy for that.
Well first, you cannot just uncomment them all, some functions still do not exist.
For example madoheal is not a working function.
Second I have finished them, I just need a final approval before they can be comitted, awaiting on euphy for that.
Originally posted by darristan
Error syntax in item_db_re line 5469, anyone confirm?
It should look like:
Instead of
Error syntax in item_db_re line 5469, anyone confirm?
REPLACE INTO `item_db_re` VALUES (12392,'Repair_A','Repair A',0,220,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,/*' madoheal rand(200,300),0;'*/,NULL,NULL); REPLACE INTO `item_db_re` VALUES (12393,'Repair_B','Repair B',0,500,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,/*' madoheal rand(300,400),0;'*/,NULL,NULL); REPLACE INTO `item_db_re` VALUES (12394,'Repair_C','Repair C',0,1100,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,/*' madoheal rand(400,500),0;'*/,NULL,NULL);
It should look like:
'/* madoheal rand(400,500),0;*/'
Instead of
/*'madoheal rand(400,500),0;'*/
Edited by darristan, 20 October 2012 - 04:31 AM.
Originally posted by Euphy
Spre committed his changes in [rev=16822], followed up with Darristan's corrections in [rev=16823] - thanks!
Spre committed his changes in [rev=16822], followed up with Darristan's corrections in [rev=16823] - thanks!
Originally posted by EvilPuncker
spre missed a item with rentitem,xxxx,1,xxxxx
spre missed a item with rentitem,xxxx,1,xxxxx
Originally posted by kyeme
Hello Hi Hello Hi, hmm what is the difference between bCastrate and bVariableCastrate ?
Hello Hi Hello Hi, hmm what is the difference between bCastrate and bVariableCastrate ?
Originally posted by Spre
firs thing is first.
it doesn't matter about anything in between /* */ those are comments, that part of the script is not read, so How exactly can you get a syntax error? Nothing there defaults to NULL as it should be untill madoheal is written.
Second Puncker read below
Third bCastrate Doesn't work right, there was a bugreport on this, the function doesn;t work as intedid or was removed I can not remember, bvariablecastrate works just as good, and that change was done a few revisions ago.
wait, I didnt mess up, item_db_re.sql says this
REPLACE INTO `item_db_re` VALUES (13694,'Freyja_Crown_Box','Freya\'s Crown Box',18,NULL,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5306,1,604800;',NULL,NULL);
GETITEM So something is not right here
puncker I need you to post this ,1, as I don;t see it missed in my diff.
firs thing is first.
it doesn't matter about anything in between /* */ those are comments, that part of the script is not read, so How exactly can you get a syntax error? Nothing there defaults to NULL as it should be untill madoheal is written.
Second Puncker read below
Third bCastrate Doesn't work right, there was a bugreport on this, the function doesn;t work as intedid or was removed I can not remember, bvariablecastrate works just as good, and that change was done a few revisions ago.
wait, I didnt mess up, item_db_re.sql says this
REPLACE INTO `item_db_re` VALUES (13694,'Freyja_Crown_Box','Freya\'s Crown Box',18,NULL,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5306,1,604800;',NULL,NULL);
GETITEM So something is not right here
puncker I need you to post this ,1, as I don;t see it missed in my diff.
Originally posted by EvilPuncker
13694,Freyja_Crown_Box,Freya's Crown Box,18,0,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5306,1,604800; },{},{}
so i mean u forgot to change it to rentitem and to remove the 1,
13694,Freyja_Crown_Box,Freya's Crown Box,18,0,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5306,1,604800; },{},{}
so i mean u forgot to change it to rentitem and to remove the 1,
Edited by EvilPuncker, 22 October 2012 - 02:37 AM.
Originally posted by kyeme
@all "bonus bCastrate" is not working in Renewal mode? asking..
IF not working, some of items have bonus bCastrate like Berzebub_Card
and create a new report about this?
@all "bonus bCastrate" is not working in Renewal mode? asking..
IF not working, some of items have bonus bCastrate like Berzebub_Card
and create a new report about this?
Edited by kyeme, 22 October 2012 - 03:05 AM.
Originally posted by Spre
Puncker: It was like that and I follow the Do not change unless it has reliable sources, as it was getitem before I updated the items, and have no confirmation it is rentitem I can not change it, I would have every db/script/core dev on my butt for making a change that is not confirmed.
So until then it has to stay getitem
Kyeme: All bCastrate should have been changed to bVariableCastrate, But going over the re itemDB I can see no, I changed all the bonus2 castrate but never did the bonus castrate. I will get on that.
Puncker: It was like that and I follow the Do not change unless it has reliable sources, as it was getitem before I updated the items, and have no confirmation it is rentitem I can not change it, I would have every db/script/core dev on my butt for making a change that is not confirmed.
So until then it has to stay getitem
Kyeme: All bCastrate should have been changed to bVariableCastrate, But going over the re itemDB I can see no, I changed all the bonus2 castrate but never did the bonus castrate. I will get on that.
Originally posted by Spre
Fixed in [rev=16828]
13694,Freyja_Crown_Box,Freya's Crown Box,18,0,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5306,1,604800; },{},{}so i mean u forgot to change it to rentitem and to remove the 1,
Fixed in [rev=16828]