Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #006856

  • 1 - Low

  • Fixed

Issue Confirmations

  • Yes (2)No (0)
Photo

quest_shop - custom npc

Posted by Hercules Bot on 05 November 2012 - 01:10 PM

Originally posted by AnnieRuru
http://trac.rathena....t/16858/rathena
http://www.eathena.w...er&showbug=1472

change
atcommand "@changelook 3 "+@qe3;
atcommand "@changelook 1 "+@qe4;
atcommand "@changelook 2 "+@qe5;
into
changelook 3, @qe3;
changelook 4, @qe4;
changelook 5, @qe5;

*setlook <look type>,<look value>;
*changelook <look type>,<look value>;

'setlook' will alter the look data for the invoking character. It is used
mainly for changing the palette used on hair and clothes: you specify which look
type you want to change, then the palette you want to use. Make sure you specify
a palette number that exists/is usable by the client you use.
'changelook' works the same, but is only client side (it doesn't save the look value).

*setlook and *changelook script command behave differently
setlook is use for stylist npc
changelook is use for headgear preview npc and item database script ( just like *changebase )

Originally posted by EvilPuncker
lol I was just about to post it

Originally posted by Joseph
Fixed in [rev=16862].

Originally posted by Brian
Thanks AnnieRuru. The last remaining [wiki='atcommand'] are:

[svn=trunk/npc/custom/etc/floating_rates.txt] (no equivalent script command exists)
atcommand "@reloadmobdb";

[svn=trunk/npc/custom/etc/monster_arena.txt] /...
atcommand strcharinfo(0) + "@option 64 0 64";

[svn=trunk/npc/custom/etc/shifty_assassin.txt] (can be replaced with [wiki='percentheal'] -100,0; )
atcommand strcharinfo(0) + "@kill "+@name$;
The more I looked at this script, the more I wanted to rewrite it.

Originally posted by AnnieRuru
well, not sure if I can post something on a bug report that already fix

1.
atcommand @reloadmobdb is intended to be working that way
because atcommand will create log at log.atcommandlog
a gm can search inside atcommandlog to see when was the last time the server reload the rates
I also used it to check inside log.atcommandlog to see the script broken on live server or not
so this one is working as intended
unless you guys suggest to do something about it


2.
our script command version setoption can only set the 1st parameter
but the atcommand version can also change 2nd and 3rd parameter
so ... atcommand to use @option is the only way to simulate permanent ....
wait ... 0x40 for 3rd parameter is the same as *pcblockmove
... rofl ... you're right...
it can be replace with pcblockmove + gm hide (setoption 0x40)

however I remember Information's party vs party script ( which is bugged and outdated )
his script used atcommand "@option 6 0 64"; to let player choose to become a spectator
6 = petrify but still can move + 64 = gm hide
so there's no way other players can interrupt the match
I don't think with setoption alone can simulate this effect
even malufett also use atcommand there
unless you guys added setoption2 and setoption3


3.
that script is way too .......
.........
... no comment xD


btw I think its better to close this one and move this discussion into
SVN development - script discussion

Edited by AnnieRuru, 05 November 2012 - 11:36 PM.