Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #006895

  • 4 - High

  • Fixed

Issue Confirmations

  • Yes (3)No (0)
Photo

Trade Zeny Bug

Posted by Hercules Bot on 13 November 2012 - 08:23 PM

Originally posted by cataclysmro
Using the latest SVN r16923, there is a zeny bug. If you deal your zeny with other players, even the deal is a success, your zeny havent changed and the worst is, the other player received the zeny. So they both have the zeny.

Originally posted by GM Takumirai
This will abuse the zeny.. oh no :(

Originally posted by cataclysmro
and yes, by the way, you have to change character first to take effect. it already happened in my server :(

Edited by cataclysmro, 13 November 2012 - 10:28 PM.


Originally posted by MarkZD
In my opnion we should just revert the trade.c as it'll be much more simple and elegant than creating some if else to see if the value is negative, turn it positive and call pc_payzeny.

Originally posted by exneval
seems like after 16914 especially the zeny stuff change, make the server unstable,
my server was crashed 3 times in one day, and dunno what the cause

Edited by exneval, 14 November 2012 - 02:02 AM.


Originally posted by mofo
i manually reverted the "zeny" changes in 16914. it seemed unnecessary, no offense to the person who changed it but it was really more trouble than it's worth.

Originally posted by Lighta
[rev=16924]

Originally posted by GM Takumirai
I learned some lesson that i must backup first in every updates i made.. so that if something wrong i can roll back the server.. thanks for the fix light