Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #006896

  • 1 - Low

  • Fixed

Issue Confirmations

  • Yes (1)No (2)
Photo

Warning in r16924

Posted by Hercules Bot on 14 November 2012 - 04:00 AM

Originally posted by kyeme
warning C4033: 'pc_paycash' must return a value
warning C4033: 'pc_getcash' must return a value
warning C4715: 'pc_paycash' : not all control paths return a value
warning C4715: 'pc_getcash' : not all control paths return a value

Originally posted by exneval
manual update?
you should double check again

Edited by exneval, 14 November 2012 - 04:15 AM.


Originally posted by kyeme
Hmm but when i reverted to 16923 no warnings.

Originally posted by malufett
http://trac.rathena....4/rathena#file4
check this Lighta put a return value for each functions..

:meow:

Originally posted by Ryuuzaki
@kyeme had the same problem, following fixed it for me (the compiler functions properly, as well as the functions ingame)
The null was set to void instead of standart one.

Look for:

nullpo_retv(sd);

Change to:

nullpo_ret(sd);

Originally posted by Lighta
yeah sorry I just tought of nullpo after,, you'll need some nullpo_retr(-1,sd) instead cause the nullpo_ret(sd) will return 0  wich will be understand like a good result for the command.
(well doesn't matter that much but the real fix should be -1 or so.)
thx for the report

Originally posted by kyeme
Fixed in r16927 thanks to all! :)

Edited by kyeme, 15 November 2012 - 05:09 AM.


Originally posted by Cookie
Marking fixed per Ind's commit [rev=16927].