Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #007014

  • 0 - None Assigned

  • Fixed

Issue Confirmations

  • Yes (4)No (0)
Photo

Minstrel Chorus skills

Posted by Hercules Bot on 17 December 2012 - 06:58 PM

Originally posted by szarkab123
Minstrel Chorus skills can be played alone. Rathena Rev. 17026

Posted Image

Originally posted by Majinken
+1

I made a bug report on this a long time ago. The skills were supposedly fixed, but can still be cast alone.

moved issue from Skills

maybe [this] will fix it

Index: map/unit.c
===================================================================
--- map/unit.c	(revision 17102)
+++ map/unit.c	(working copy)
@@ -1116,6 +1116,15 @@
	 tstatus = status_get_status_data(target);
	 // Record the status of the previous skill)
	 if(sd) {
+		if( skill_get_inf2(skill_id)&INF2_CHORUS_SKILL )
+		{
+			if( skill_check_pc_partner(sd,skill_id,&skill_lv,skill_get_splash(skill_id,skill_lv),0) < 1 )
+			{
+			   clif_msg(sd, 0x583);
+				return 0;
+			}
+		}
+		else
		 switch(skill_id){
		 case SA_CASTCANCEL:
			 if(ud->skill_id != skill_id){



changed status to: Confirmed

changed status to: Fixed

@Mysterious
even though its not how the official works anyway thanks for Kichi and you for the effort...:)

Fixed @ https://github.com/H...54da4222cb72734
:meow:

moved issue from Archer Classes