[High Wizard Card] ignores mdef partially

@src/map/battle.c

		if(sd) {
			//Damage bonuses
			if ((i = pc_skillatk_bonus(sd, skill_id)))
				ad.damage += ad.damage*i/100;


			if( (i = battle_adjust_skill_damage(src->m,skill_id)) )
				MATK_RATE(i);


			//Ignore Defense?
			if (!flag.imdef && (
				sd->bonus.ignore_mdef_ele & ( 1 << tstatus->def_ele ) ||
				sd->bonus.ignore_mdef_race & ( 1 << tstatus->race ) ||
				sd->bonus.ignore_mdef_race & ( is_boss(target) ? 1 << RC_BOSS : 1 << RC_NONBOSS )
			))
				flag.imdef = 1;
		}


		if(!flag.imdef){
			defType mdef = tstatus->mdef;
			int mdef2= tstatus->mdef2;
#ifdef RENEWAL
			if(tsc && tsc->data[SC_ASSUMPTIO])
				mdef <<= 1; // only eMDEF is doubled
#endif
			if(sd) {
				i = sd->ignore_mdef[is_boss(target)?RC_BOSS:RC_NONBOSS];
				i+= sd->ignore_mdef[tstatus->race];
				if (i)
				{
					if (i > 100) i = 100;
					mdef -= mdef * i/100;
					//mdef2-= mdef2* i/100;
				}
			}
		#ifdef RENEWAL
			/**
			 * RE MDEF Reduction
			 * Damage = Magic Attack * (1000+eMDEF)/(1000+eMDEF) - sMDEF
			 **/
			ad.damage = ad.damage * (1000 + mdef) / (1000 + mdef * 10) - mdef2;
		#else
			if(battle_config.magic_defense_type)
				ad.damage = ad.damage - mdef*battle_config.magic_defense_type - mdef2;
			else
				ad.damage = ad.damage * (100-mdef)/100 - mdef2;
		#endif
		}

as the code says it ignores both...

if (i) { if (i > 100) i = 100; mdef -= mdef * i/100; //mdef2-= mdef2* i/100;

...
So, only mdef is ignored.. mdef2 isn't the same.

Practical tests root for my theory.

btw: assumptio increases def/mdef by 35% in pvp/woe instead of 100%.

Edited by KyleZ, 18 February 2013 - 07:00 AM.

wait what are you pertaining to?? the partial ignore mdef or the 100% ignore mdef??

I meant that Samurai Spector Card ignores both Def1 and Def2 100%, while High Wizard Card ignores ONLY mdef1 100%.

Although they have similar description

Samurai Spector Card: Physical attacks ignore the defense of normal monsters and players.
High Wizard Card: Magic attacks ignore the defense of all targets.

I feel sorry for mdef2, kind of mistreated LOL..

High Wizard Card uses 'bIgnoreMDefRace' therefore 'flag.imdef = 1;' will trigger so it will ignore both hard and soft..

errr..
Sorry Katrinn, you're the collateral damage.. LOL

I thought its function was bIgnoreMdefRate, which ignores ONLY hard mdef.

malufett, you design these bonuses, is it intended for bIgnoreMdefRate? If so, i have nothing to complain..

malufett, you design these bonuses, is it intended for bIgnoreMdefRate? If so, i have nothing to complain..

no I'm not...hahaha..wait I'll check kRO if what does partial ignore mdef does..I'll try using piercing staff..

Too bad, the MVP card seller was removed in pRO Sakray Sorry i cant help  

@kyeme

thanks all the same.

@malufett

yeah, piercing staff sounds like a good idea, or KVM gears if you have them

Since the item bonus itself is fine and this discussion is related to the mechanics behind the bonus I'll move this to the core section.