Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

Issue Confirmations

  • Yes (1)No (0)
Photo

Warp or Close2(NPC Script)

Posted by Potato on 24 February 2013 - 01:29 AM

stopped working at the current revision. not really sure if its just me can anyone verify?

Tested on
Eden Officer Warper
and a Custom Npc that uses warp and close2

Kafra works fine though

Ind 
changed severity to: 4 - High
changed status to: Confirmed

I'm not yet aware of the reason behind this change, but if you need a quick workaround till its discovered in script.c find
BUILDIN_FUNC(close2)
{
	TBL_PC* sd;

	sd = script_rid2sd(st);
	if( sd == NULL )
		return 0;

	st->state = STOP;
	clif_scriptclose(sd, st->oid);
	return 0;
}
and change to
BUILDIN_FUNC(close2)
{
	TBL_PC* sd;

	sd = script_rid2sd(st);
	if( sd == NULL )
		return 0;

	st->state = END;
	clif_scriptclose(sd, st->oid);
	return 0;
}


changed status to: Fixed

After this update, custom npc script like healer/breeder, make you stuck 4ever

After this update, custom npc script like healer/breeder, make you stuck 4ever

this is a script bug not a core bug, the npc is using 'close' instead of 'end'

so what the doc says is not true

This command will create a 'close' button in the message window for the invoking
character. If no window is currently on screen, the script execution will end. This is one
of the ways to end a speech from an NPC. Once the button is clicked, the NPC
script execution will end, and the message box will disappear.



actually we are going to change that too..
cause also in official they use end to terminate the script and close to only show the close button...

:meow: