Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #007098

  • 0 - None Assigned

  • Working as Intended

Issue Confirmations

  • Yes (0)No (0)
Photo

GTB (when using the % blocking instead of full immunity to magic) issue

Posted by jTynne on 26 February 2013 - 01:11 AM

The issue is that when wearing a GTB card using the following script:
bonus bNoMagicDamage,85;
(85% magic resist)

Magic Rod does NOT consume single-target spells as it should.

to my knowledge magic rod is supposed to always fail with gtb regardless of the percentage (code currently does that too)

Hrm, logically though since the % is (likely?) custom, that it should be an option to absorb the single-target magic coming in still? I understand GTB blocks the magic damage in general, but confused why Magic Rod fails when a % is used instead of 100% immunity. Strangeness D:

Thanks Ind!

Ind 
changed status to: Working as Intended

Its because it doesn't check for the value, as long as you have 1% it'll block
	//Status that are blocked by Golden Thief Bug card or Wand of Hermod
	if (status_isimmune(bl))
		switch (type) {
			case SC_DECREASEAGI:
			case SC_SILENCE:
			case SC_COMA:
			case SC_INCREASEAGI:
			case SC_BLESSING:
			case SC_SLOWPOISON:
			case SC_IMPOSITIO:
			case SC_AETERNA:
			case SC_SUFFRAGIUM:
			case SC_BENEDICTIO:
			case SC_PROVIDENCE:
			case SC_KYRIE:
			case SC_ASSUMPTIO:
			case SC_ANGELUS:
			case SC_MAGNIFICAT:
			case SC_GLORIA:
			case SC_WINDWALK:
			case SC_MAGICROD:
			case SC_HALLUCINATION:
			case SC_STONE:
			case SC_QUAGMIRE:
			case SC_SUITON:
			case SC_SWINGDANCE:
			case SC__ENERVATION:
			case SC__GROOMY:
			case SC__IGNORANCE:
			case SC__LAZINESS:
			case SC__UNLUCKY:
			case SC__WEAKNESS:
			case SC__BLOODYLUST:
				return 0;
		}
status_isimmune returns how much magic ignore you have, you can modify the SC_MAGICROD case if you like