Issue Information
-
#007183
-
0 - None Assigned
-
Fixed
Issue Confirmations
-
Yes (0)No (0)
1
Any work in progress (NPC dialog, manufactoring,,,) quit and try again.
Posted by bgamez23 on 23 April 2013 - 03:04 PM
this is happen when i try to move to the mvp and use heal.
how to produce.
just take a heal at the npc, then try to move, or use some skill the problem will occur.
Any work in progress (NPC dialog, manufactoring,,,) quit and try again.
you must relogin to remove that problem.
how to produce.
just take a heal at the npc, then try to move, or use some skill the problem will occur.
Any work in progress (NPC dialog, manufactoring,,,) quit and try again.
you must relogin to remove that problem.
Mhmhmh, odd...
Well, I'll commit that fix later today, but it seems there is a bug with switch or select command.
Well, I'll commit that fix later today, but it seems there is a bug with switch or select command.
hmmm i'm not sure sir because i just notice this bug since the implementation of close to end function for the script.Mhmhmh, odd...
Well, I'll commit that fix later today, but it seems there is a bug with switch or select command.
Acute bug fixed in https://github.com/H...2a764fabba1bf5f
This report remains open because of the odd behaviour.
This report remains open because of the odd behaviour.
thank you Kenpachi I'll try to fix this odd thing
identified the issue, will commit soon
i think the problem sir was on the src\map\script.cidentified the issue, will commit soon
/// Ends the script and displays the button 'close' on the npc dialog.
/// The dialog is closed when the button is pressed.
///
/// close;
BUILDIN(close)
{
TBL_PC* sd;
sd = script_rid2sd(st);
if( sd == NULL )
return true;
st->state = CLOSE;
clif->scriptclose(sd, st->oid);
return true;
}
and i replace the
/// Ends the script and displays the button 'close' on the npc dialog.
/// The dialog is closed when the button is pressed.
///
/// close;
BUILDIN(close)
{
TBL_PC* sd;
sd = script_rid2sd(st);
if( sd == NULL )
return true;
st->state = END;
clif->scriptclose(sd, st->oid);
return true;
}
after i change it there is no problem regarding on the npc even i reverted back the old script still working on the latest revision.
Alternatively I'd have tried using a combination of
The close button is supposed to work that way, that it only works and ends correctly with dialogs, since there is a no dialog there it can't really end. But again since I can't test it I'd have to rely on others confirming it, or waiting until I can get my desktop back up and running.
close2;followed by
end;and see if that would've resolved it.
The close button is supposed to work that way, that it only works and ends correctly with dialogs, since there is a no dialog there it can't really end. But again since I can't test it I'd have to rely on others confirming it, or waiting until I can get my desktop back up and running.
Tried, not working.
still waiting for official fix.
but I fixed this O_O~ uh maybe i forgot to update this or didnt commit it from my working copy, lemme check
the link that you post is Navigation system?Yup it was fixed here
https://github.com/H...d89e10cd9a4b972
the link that you post is Navigation system?
Yup it was fixed here
https://github.com/H...d89e10cd9a4b972
No, he linked you to the commit that fixes the dialogue issue as discussed in this bug report.
