Issue Information
-
#007210
-
2 - Fair
-
Needs More Info
Issue Confirmations
-
Yes (0)No (0)
0
Refering to this bug report the itemskill command should check for required items and show the "Skill has failed." message if necessary. Maybe an optional parameter (0 or 1) is the best way to add this feature.
ah there is a trick. something in the requirement stuff will block this fix =_=
if( sd->skillitem == skill_id ) return req; // Item skills and Hocus-Pocus don't have requirements.[Inkfish]
the comment above ^ makes me wonder, this requires a new script command OR all itemskill casts require comments and inkfish's fix is wrong?
@offtopic
@Sir Ind, is this possible to add flag to consume the item immediately? Issue
This must be handled by the item type, not the bonus. I'm aware of that issue and will be investigating it next week.
what about the inkfish thing oo all itemskills' should check requirements or selected ones?
And yes, all official item scripts which make use of itemskill should check for the required items and states. (skill_require_db.txt) If there is an item which does not make use of this I can simply set the optional flag, so don't worry.
alright I'll dump the blocked sections, thank you 
But pay attention when removing that block. Hocus-Pocus should not check the requirements.
But it still consume SP :/
I've reverted and am waiting for more information, this all-or-none thing was breaking behavior for a high number of items.
We can test this on ~aegis server~
