Issue Information
-
#007221
-
New
Issue Confirmations
-
Yes (0)No (0)
0
In official the damage bonus of Shield is +50 per refine not +10
Source pRO
Please confirm this.ATK_ADD(10*sd->status.inventory[index].refine);
Source pRO
It's 10 per hit. Shield Chain does 5 hits, so it's 50 more damage total per refine.
Up~~~~~~
Are you sure this is not working?
Because:
Because:
The video shows it's already working, isn't it?It's 10 per hit. Shield Chain does 5 hits, so it's 50 more damage total per refine.
Are you sure this is not working?
Because:The video shows it's already working, isn't it?
It's 10 per hit. Shield Chain does 5 hits, so it's 50 more damage total per refine.
The video was from Official server
Ah I see. And on Herc it's only 2 damage per hit?
Edit:
Hmm, yes I see it in the code. The problem is that the damage increase comes at the very end where damage_div_fix was already called (that multiplies damage by number of hits). Officially damage_div_fix actually comes last (even after plant damage), but it's hard to move down without breaking all the skills that add damage in between. (Also because of how the DEF is applied to single hits.)
Can't just change the 10 to 50 either because the code is also used for CR_SHIELDBOOMERANG.
Easiest way to fix is to apply div_ again:
This needs to be fixed by Herc as on rAthena we already reworked the damage code for weapon attacks to have a better order of processing, so it's already working there.
Edit:
Hmm, yes I see it in the code. The problem is that the damage increase comes at the very end where damage_div_fix was already called (that multiplies damage by number of hits). Officially damage_div_fix actually comes last (even after plant damage), but it's hard to move down without breaking all the skills that add damage in between. (Also because of how the DEF is applied to single hits.)
Can't just change the 10 to 50 either because the code is also used for CR_SHIELDBOOMERANG.
Easiest way to fix is to apply div_ again:
ATK_ADD(10*sd->status.inventory[index].refine*wd.div_);Long term, the whole div fix should be moved to the end of the damage code, though.
This needs to be fixed by Herc as on rAthena we already reworked the damage code for weapon attacks to have a better order of processing, so it's already working there.
Edited by Playtester, 07 November 2014 - 07:44 AM.
