Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #007307

  • 0 - None Assigned

  • Fixed

Issue Confirmations

  • Yes (1)No (0)
Photo

Status Weapon Switch

Posted by kyeme on 31 May 2013 - 01:05 PM

Example:
When you cast Asura Strike while wearing Bloody Weapon ( Hydra ) and switched quickly to ( Stormy Knight ) Weapon. The damage inflicted by the Bloody Weapon still take effect and at the same time the Status effect of the ( stormy knight card) takes effect as well ( Frost ) so what happens is, you get the damage from the Bloody and still get frozen after.

Here's my Video: Using Quad Bloody damage around 5k and @ 0:57Using Bloody and switch to Stormy Card damage 5k and get frozen.




http://rathena.org/b...7107#entry17107

i dont see this being possible huhu o__o~ it'd be more easy to understand the hydra weapon being broken hmmm whats asura damage with the stormy weapon?

Iv make a new video:



Asura with +0 double bloody double bone mace [4] = 5,294
Asura with +0 Quad StormyKnight mace [4] = 3.4k

In the video you can see my damage is 5,294 but the High orc got frozen because of switching bug.

To reproduce:
Before casting bar end. . switch to status weapon (stormy card, etc. )

Ind 
changed status to: Confirmed

ah i understand now how its possible thanks for the video.

Ind 
changed status to: Started

Ind 
changed status to: Fixed

Yahoooooo! THANK YOU!! :)

Edited by kyeme, 06 July 2013 - 02:08 AM.


When i tried to switch my weapon quickly after i cast my skill, i'd got this msg "You can't put this item on" or you unable to change your weapon.
Is this intentional? :)

Edited by kyeme, 06 July 2013 - 05:59 AM.


When i tried to switch my weapon quickly after i cast my skill, i'd got this msg "You can't put this item on" or you unable to change your weapon.
Is this intentional? :)

I'd say its intentional, the fix to this makes character unable to change gear while any skill previously cast hasn't completed processing -- this avoids any gear change to affect damage/post-effect. (in most skills this is instantly and unnoticeable though)



When i tried to switch my weapon quickly after i cast my skill, i'd got this msg "You can't put this item on" or you unable to change your weapon.
Is this intentional? :)

I'd say its intentional, the fix to this makes character unable to change gear while any skill previously cast hasn't completed processing -- this avoids any gear change to affect damage/post-effect. (in most skills this is instantly and unnoticeable though)


But Sir, the way you fixed the bug the official bahavior of switching weapons are broken. Just like Clowns that cant switch faster from guitar to dagger.  :o

I don't know if this is related to this bugfix but...

It seems that in some way, after several minutes playing, you can't switch any weapon/equipment. It just doesn't work. You need to relog to be able to switch equipment again. This affects arrows too.

I don't know if this is related to this bugfix but...

It seems that in some way, after several minutes playing, you can't switch any weapon/equipment. It just doesn't work. You need to relog to be able to switch equipment again. This affects arrows too.

I can confirm this, related ithink :)

hmm..I tried to investigate I reverted Ind's fixed and I tried to mimic Kyeme's video and used some debug message in the server and it shows that the problem doesn't exist in Hercules..only tested in Re..but let me test again in Pre..

:meow:

I'm using RE, but I still don't know how to reproduce... because doing the same actions, the first time it worked but the second time it didn't. Weird, so weird.




When i tried to switch my weapon quickly after i cast my skill, i'd got this msg "You can't put this item on" or you unable to change your weapon.
Is this intentional? :)

I'd say its intentional, the fix to this makes character unable to change gear while any skill previously cast hasn't completed processing -- this avoids any gear change to affect damage/post-effect. (in most skills this is instantly and unnoticeable though)

But Sir, the way you fixed the bug the official bahavior of switching weapons are broken. Just like Clowns that cant switch faster from guitar to dagger. :o

I'll take a look

hmm..I tried to investigate I reverted Ind's fixed and I tried to mimic Kyeme's video and used some debug message in the server and it shows that the problem doesn't exist in Hercules..only tested in Re..but let me test again in Pre..

:meow:

I think the problem is in the timing (in your testing), as i understand (i can of course be wrong if you know it to be otherwise please tell me =3) there is nothing in the code that prevents it from happening (without the fix) regardless of pre-re or RE, damage is calculated before delay_damage is called, then when it is cast it calls a timer, so it is possible (without the fix) to switch gear during that timer, when the timer ends it calls:
if( dat->attack_type && !iStatus->isdead(target) && dat->additional_effects ) skill->additional_effect(src,target,dat->skill_id,dat->skill_lv,dat->attack_type,dat->dmg_lv,tick); if( dat->dmg_lv > ATK_BLOCK && dat->attack_type ) skill->counter_additional_effect(src,target,dat->skill_id,dat->skill_lv,dat->attack_type,tick);
which would trigger any effects of the weapons changed afterwards


I don't know if this is related to this bugfix but...

It seems that in some way, after several minutes playing, you can't switch any weapon/equipment. It just doesn't work. You need to relog to be able to switch equipment again. This affects arrows too.

I can confirm this, related ithink :)

Do you have any info that can help me into reproducing this? I couldn't


I don't know if this is related to this bugfix but...

It seems that in some way, after several minutes playing, you can't switch any weapon/equipment. It just doesn't work. You need to relog to be able to switch equipment again. This affects arrows too.

I can confirm this, related ithink :)

I think I see how this could happen, might have been fixed in https://github.com/H...8e6f6a781c2b640

Yep, I am able to reproduce this before https://github.com/H...8e6f6a781c2b640 but it should be fixed now. Is it still not fixed for you kyeme?

Yep, I am able to reproduce this before https://github.com/H...8e6f6a781c2b640 but it should be fixed now. Is it still not fixed for you kyeme?

The "can't switch item" issue that posted by Zopokx was already fixed.
The only problem now is "official bahavior of switching weapons are broken. Just like Clowns that cant switch faster from guitar to dagger."

Edited by kyeme, 19 July 2013 - 02:27 PM.